Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build

[Andy Wingo <wingo@igalia.com>]

Hi :)

On Fri 24 Feb 2017 13:40, "Huang, Ying" <huang_ying_caritas@163.com> writes:

>>    (define (union output inputs)
>>      (match inputs
>>        ((input)
>> -       ;; There's only one input, so just make a link.
>> -       (symlink* input output))
>> +       ;; There's only one input, so just make a link unless create-all-directory?

This comment should be a full sentence ending with a period, with line
wrapped at 72 columns.

>> +       (if (and create-all-directory? (file-is-directory? input))
>> +           (union-of-directories output inputs)
>> +           (symlink* input output)))

What's the use case?  Something that can handle some symlinks in the
tree but not all symlinks in the tree?  I think this patch is a bad idea
for union-build because it has a strange effect that's hard to describe
up and down the union (both at the root and at branch directories).  I
think it's probably a better idea to go for something more fit to your
purpose and only pull it into union-build once you see yourself needing
it more than once.  IMO anyway :)

Andy