unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Fetching patches as origins instead of copying them into the Guix Git repo
Date: Sat, 02 Sep 2017 22:55:44 +0200	[thread overview]
Message-ID: <877exgx1kf.fsf@gnu.org> (raw)
In-Reply-To: <87shg7l812.fsf@fastmail.com> (Marius Bakke's message of "Thu, 31 Aug 2017 23:52:25 +0200")

Hello,

Marius Bakke <mbakke@fastmail.com> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Thu, Aug 31, 2017 at 09:52:49PM +0200, Marius Bakke wrote:
>>> Side note: I think we should start adding patches as origins instead of
>>> copying them wholesale, to try and keep the git repository slim.

[...]

> No, I mean adding patches like this:
>
> (define %CVE-1970-0001.patch
>   (origin
>     (method url-fetch)
>     (uri "https://example.com/CVE-2017-0001.patch")
>     (sha256
>      (base32
>       "12c60iwxyc3rj6ih06a1g80vmkf8khvhm44xr9va4h21b74v8f5k"))))
>
> (package
>  (...
>   (patches (list (search-patch "guix-specific-stuff.patch")
>                  %CVE-1970-0001.patch)))
>
> That only requires the built-in guix downloader.

I agree, I did that a few times for this reason.

Once I did that for Coreutils, fetching the patch via a Cgit URL at
Savannah, and somehow that URL went broken at some later point, which
was annoying.  But in general, it shouldn’t be worse than source URLs
that go 404.

Ludo’.

      parent reply	other threads:[~2017-09-02 20:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87inh5uqpd.fsf@gmail.com>
     [not found] ` <87inh4lw7y.fsf@fastmail.com>
     [not found]   ` <87y3q0ow9h.fsf@gmail.com>
     [not found]     ` <87k21jjyzy.fsf@fastmail.com>
2017-08-31 21:38       ` Fetching patches as origins instead of copying them into the Guix Git repo Leo Famulari
2017-08-31 21:52         ` Marius Bakke
2017-09-01  9:58           ` ng0
2017-09-01 10:03             ` ng0
2017-09-01 19:50           ` Leo Famulari
2017-09-02 17:09           ` Alex Vong
2017-09-04 18:47             ` Marius Bakke
2017-09-02 20:55           ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877exgx1kf.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).