From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Kebreau Subject: Re: 01/01: gnu: Put autoconf-related phases immediately after the 'unpack phase. Date: Tue, 05 Sep 2017 08:39:54 -0400 Message-ID: <877exde2ud.fsf@posteo.net> References: <20170904041130.27802.58770@vcs0.savannah.gnu.org> <20170904041131.AE33520DD3@vcs0.savannah.gnu.org> <87wp5enr9l.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpD9Y-00055F-E2 for guix-devel@gnu.org; Tue, 05 Sep 2017 08:40:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpD9T-0000mF-4U for guix-devel@gnu.org; Tue, 05 Sep 2017 08:40:28 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40470) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpD9S-0000j5-PI for guix-devel@gnu.org; Tue, 05 Sep 2017 08:40:23 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 39A6020AD0 for ; Tue, 5 Sep 2017 14:40:14 +0200 (CEST) In-Reply-To: <87wp5enr9l.fsf@netris.org> (Mark H. Weaver's message of "Mon, 04 Sep 2017 16:27:34 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark H Weaver writes: > kkebreau@posteo.net (Kei Kebreau) writes: > >> kkebreau pushed a commit to branch master >> in repository guix. >> >> commit d10092b849153dc27cfed0a9601fde6c7bdec918 >> Author: Kei Kebreau >> Date: Sun Jul 30 21:02:35 2017 -0400 >> >> gnu: Put autoconf-related phases immediately after the 'unpack phase. >>=20=20=20=20=20 >> * gnu/packages/audio.scm (audacity, rtmidi)[arguments]: Correct phas= es >> accordingly. >> * gnu/packages/bioinformatics.scm (mash, seek, vsearch, emboss, >> htslib-for-sambamba)[arguments]: Likewise. >> * gnu/packages/ci.scm (cuirass)[arguments]: Likewise. >> * gnu/packages/compression.scm (minizip, xdelta)[arguments]: Likewis= e. >> * gnu/packages/cpp.scm (libzen)[arguments]: Likewise. >> * gnu/packages/crypto.scm (opendht)[arguments]: Likewise. >> * gnu/packages/databases.scm (4store, mdbtools)[arguments]: Likewise. >> * gnu/packages/debug.scm (stress-make)[arguments]: Likewise. >> * gnu/packages/dns.scm (dnscrypt-proxy, dnscrypt-wrapper)[arguments]: >> Likewise. >> * gnu/packages/emacs.scm (emacs-pdf-tools)[arguments]: Likewise. >> * gnu/packages/embedded.scm (libjaylink, openocd)[arguments]: Likewi= se. >> * gnu/packages/engineering.scm (gerbv)[arguments]: Likewise. >> * gnu/packages/erlang.scm (erlang)[arguments]: Likewise. >> * gnu/packages/ftp.scm (weex)[arguments]: Likewise. >> * gnu/packages/gnome.scm (dia)[arguments]: Likewise. >> * gnu/packages/gnunet.scm (gnurl, guile-gnunet)[arguments]: Likewise. >> * gnu/packages/gtk.scm (guile-rsvg, graphene)[arguments]: Likewise. >> * gnu/packages/guile.scm (guildhall, guile-ics, guile-sqlite3)[argum= ents]: >> Likewise. >> * gnu/packages/ibus.scm (ibus-libpinyin)[arguments]: Likewise. >> * gnu/packages/irc.scm (weechat)[arguments]: Likewise. >> * gnu/packages/java.scm (classpath-devel)[arguments]: Likewise. >> * gnu/packages/libreoffice.scm (libetonyek)[arguments]: Likewise. >> * gnu/packages/libusb.scm (hidapi)[arguments]: Likewise. >> * gnu/packages/linux.scm (gpm)[arguments]: Likewise. >> * gnu/packages/logging.scm (glog)[arguments]: Likewise. >> * gnu/packages/machine-learning.scm (ghmm)[arguments]: Likewise. >> * gnu/packages/mail.scm (dovecot-trees, dovecot-libsodium-plugin, es= mtp) >> [arguments]: Likewise. >> * gnu/packages/messaging.scm (freetalk, libmesode, libstrophe)[argum= ents]: >> Likewise. >> * gnu/packages/microcom.scm (microcom)[arguments]: Likewise. >> * gnu/packages/ocaml.scm (ocaml-ssl)[arguments]: Likewise. >> * gnu/packages/parallel.scm (slurm)[arguments]: Likewise. >> * gnu/packages/pdf.scm (libharu)[arguments]: Likewise. >> * gnu/packages/samba.scm (cifs-utils)[arguments]: Likewise. >> * gnu/packages/serialization.scm (msgpack)[arguments]: Likewise. >> * gnu/packages/shells.scm (scsh)[arguments]: Likewise. >> * gnu/packages/telephony.scm (libiax2)[arguments]: Likewise. >> * gnu/packages/textutils.scm (dotconf)[arguments]: Likewise. >> * gnu/packages/version-control.scm (findnewest)[arguments]: Likewise. >> * gnu/packages/video.scm (libmediainfo, mediainfo)[arguments]: Likew= ise. > > Thanks for working on this, but it looks like you didn't actually test > building the modified packages. For example: > >> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm >> index fe43d01..028fe06 100644 >> --- a/gnu/packages/java.scm >> +++ b/gnu/packages/java.scm >> @@ -685,7 +685,7 @@ the standard javac executable. The tool runs on Jam= VM instead of SableVM."))) >> "--disable-gjdoc") >> #:phases >> (modify-phases %standard-phases >> - (add-before 'configure 'bootstrap >> + (add-after 'remove-unsupported-anootations 'bootstrap >> (lambda _ >> (zero? (system* "autoreconf" "-vif")))) >> (add-after 'unpack 'remove-unsupported-annotations > > You mispelled 'annotations' in the name of the phase, and thus we lost > our Java packages. > > Since this commit, there are now 119 newly failing jobs: > > https://hydra.gnu.org/eval/109773#tabs-now-fail > > I'm not sure how many of these new failures are due to this commit, but > I suspect many of them are. > > Please test before you push to master. > > Mark This was caused by confusion on my end. I am working right now to find and fix these errors. Thank you for your notification. My apologies. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmumxoACgkQ5qXuPBlG eg0CNhAAj6/cT2tvYBvF9oMDbOwl3wUNwtefr6fd5OibZr/w9t31uOLOZJYb5Go3 lchflg2hOJ2E6Assk9gDTuVxeUHZeOYBlhdQ4YpBT71owToaE1bMrHYrQQAFi/NQ b4GxB1+tMAWg/8EKfU87W0axRELyWwshDUVJ+00CldPHujmfh4q5/o1tP28m2a5c 2RiYkKj9v8L0eFNg/waUGMEzPf5lG7EigVIL7F2Gx/BRcipG1xRfaVpIH3ivEmad s+JR9CZ/9bsiahBP2tMGB/2kMUs1ekq/mFfXxo6JV4ebeVn9jCxDfl8kRRreZIoK om01uYHP0ko4RAkYoZrUd5Qes6oLrSMJYBJEScC5daN2jF3ZGGW2NDVM/d3qrngT 4Y72bb2nAntfkj1BJonGZe0vUOWDniP3YGkTvfVJud+Lkuzy0YKw8u/eTanY2QR8 xTd/LoAbWSAgIZCmeD/ZKrxqEK7p8DJxydXhe9M9xWf3a5zWFIvecRUE37alYMCS xGU8cI+NRoDIFrW7DsPx0k01TEfn/V3D0HtGsyz+E932fh7HG89BsmuURCR7wAqW h3Jdi6BdEpW9QvR8d+Gu5gPQCbU6YapYeZ5ZZdMEO+AgbN7X8C3DY6rij3LVXVkF gJ9rTwvwmLEBJjrJNDAYJablSIyjH3eC+7PRVc/qkqz2gyhIuOA= =xtz7 -----END PGP SIGNATURE----- --=-=-=--