From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Changing HTTP proxy settings in GuixSD
Date: Sat, 11 Nov 2017 15:20:57 +0100 [thread overview]
Message-ID: <877euwhp6e.fsf@gnu.org> (raw)
In-Reply-To: <87wp2xdszf.fsf@netris.org> (Mark H. Weaver's message of "Sat, 11 Nov 2017 05:12:20 -0500")
Mark H Weaver <mhw@netris.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>> It turned out to come from a typo in Guile 2.2’s web client, now fixed
>> here:
>>
>> https://git.savannah.gnu.org/cgit/guile.git/commit/?h=stable-2.2&id=7d0d9e2c25c1e872cfc7d14ab5139915f1813d56
>
> [...]
>
>> diff --git a/module/web/http.scm b/module/web/http.scm
>> index 993b50e..62f0624 100644
>> --- a/module/web/http.scm
>> +++ b/module/web/http.scm
>> [...]
>> @@ -1158,7 +1158,7 @@ three values: the method, the URI, and the version."
>> (put-symbol port scheme)
>> (put-string port "://")
>> (cond
>> - ((host string-index #\:)
>> + ((string-index host #\:)
>> (put-char #\[ port)
>> (put-string port host
>> (put-char port #\])))
>
> There are 4 typos in the cond clause above, all introduced in this
> commit:
>
> https://git.savannah.gnu.org/cgit/guile.git/commit/?id=96b994b6f815747ce2548123cc996d8132bd4781
>
> which includes:
>
> - ((string-index host #\:)
> - (display #\[ port)
> - (display host port)
> - (display #\] port))
> + ((host string-index #\:)
> + (put-char #\[ port)
> + (put-string port host
> + (put-char port #\])))
>
> In addition to the typo you fixed:
>
> * The first call to 'put-char' above has its arguments reversed.
> * The following line is missing its ')'.
> * The last line has an extra ')'.
Ouch, good catch. I pushed appropriate fixes.
If you spot more, feel free to fix them directly! :-)
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-11-11 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 13:21 Changing HTTP proxy settings in GuixSD Konrad Hinsen
2017-10-27 0:41 ` Ludovic Courtès
2017-11-06 17:20 ` Konrad Hinsen
2017-11-10 5:28 ` Chris Marusich
2017-11-10 9:05 ` Konrad Hinsen
2017-11-10 22:15 ` Ludovic Courtès
2017-11-10 22:29 ` ng0
2017-11-11 10:12 ` Mark H Weaver
2017-11-11 14:20 ` Ludovic Courtès [this message]
2017-11-16 9:21 ` Konrad Hinsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877euwhp6e.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).