From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: isc-bind service draft
Date: Thu, 30 Nov 2017 18:03:40 +0100
Message-ID: <877eu73dhv.fsf@gnu.org>
References: <87vaijkyam.fsf@gmail.com> <87po8kno54.fsf@gmail.com>
	<87tvxuewmq.fsf@gmail.com> <87fu9eci4n.fsf@gnu.org>
	<87h8tkm629.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47058)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1eKSFW-0003I3-JQ
	for guix-devel@gnu.org; Thu, 30 Nov 2017 12:03:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1eKSFT-0006fr-C7
	for guix-devel@gnu.org; Thu, 30 Nov 2017 12:03:46 -0500
Received: from [141.255.128.1] (port=42338 helo=hera.aquilenet.fr)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1eKSFT-0006f8-5X
	for guix-devel@gnu.org; Thu, 30 Nov 2017 12:03:43 -0500
In-Reply-To: <87h8tkm629.fsf@gmail.com> (Oleg Pykhalov's message of "Fri, 24
	Nov 2017 11:31:10 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: guix-devel@gnu.org

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> Here is a new working in vm version.  There is still a lot work to do:
>
> - More apropriate for everyone default config.
> - Writing tests.
>
> More suggestions are welcome :-)

That looks neat!  With doc and a couple of examples, and indeed a test,
it would be perfect.  But you=E2=80=99re almost there, no?

> (define-record-type* <bind-options-configuration>
>   bind-options-configuration make-bind-options-configuration
>   bind-options-configuration?

[...]

>   (allow-recursion? bind-options-configuration-allow-recursion? ; list
>                     (default (list "127.0.0.1")))
>   (allow-transfer?  bind-options-configuration-allow-transfer?  ; list
>                     (default (list "none")))
>   (allow-update?    bind-options-configuration-allow-update?    ; list
>                     (default (list "none")))
>   (version          bind-options-configuration-version          ; string
>                     (default "none"))

As a matter of style, I would use question marks only for Booleans.
Here these appear to be enumerations and strings, no?

>   (hostname         bind-options-configuration-hostname         ; string
>                     (default (gethostname)))

Not a great default (for instance if you=E2=80=99re configuring a remote
machine).  Should we just not provide a default?

Thank you!

Ludo=E2=80=99.