From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tobias Geerinckx-Rice <me@tobias.gr>
Subject: Re: SSHv2 doesn't actually have compression levels
Date: Fri, 23 Aug 2019 00:00:43 +0200
Message-ID: <877e746et0.fsf@nckx>
References: <87ef28fflj.fsf@nckx> <87mug0j2gt.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:43473)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <me@tobias.gr>) id 1i0v8T-0007tB-Uy
 for guix-devel@gnu.org; Thu, 22 Aug 2019 18:00:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <me@tobias.gr>) id 1i0v8S-0007YI-9p
 for guix-devel@gnu.org; Thu, 22 Aug 2019 18:00:49 -0400
In-reply-to: <87mug0j2gt.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Ludo',

Welcome back :-)

Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A
> I don=E2=80=99t get it: the =E2=80=98compression-level=E2=80=99 field def=
aults to 3,=20
> and OpenSSH
> does:
>
>   static int
>   start_compression_out(struct ssh *ssh, int level)
>   {
>           if (level < 1 || level > 9)
>                   return SSH_ERR_INVALID_ARGUMENT;
>           debug("Enabling compression at level %d.", level);
>
>   [...]
>
>   }
>
> What=E2=80=99s wrong?

Exactly!

  ~/openssh-8.0p1 =CE=BB grep -r start_compression_out
  packet.c:start_compression_out(struct ssh *ssh, int level)
  packet.c:	if ((r =3D start_compression_out(ssh, 6)) !=3D 0)
  packet.c:	if ((r =3D start_compression_out(ssh, 6)) !=3D 0)

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXV8QiwAKCRANsP+IT1Vt
eXHCAQDb8yjoeviNyC0gzy5YrIzK50iwU/eV0bDFjqp2S+QncwEAoPi18GaXLK1H
YZ9Xgvus1n/kNEoxneQrP/BGL+a+kA4=
=0yu/
-----END PGP SIGNATURE-----
--=-=-=--