From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id FZ+fOA/BAGDtOAAA0tVLHw (envelope-from ) for ; Thu, 14 Jan 2021 22:09:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SBDnMw/BAGCZaQAAB5/wlQ (envelope-from ) for ; Thu, 14 Jan 2021 22:09:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 85FBB9402AF for ; Thu, 14 Jan 2021 22:09:19 +0000 (UTC) Received: from localhost ([::1]:33778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Anu-0001QY-Hf for larch@yhetil.org; Thu, 14 Jan 2021 17:09:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0AnG-0001PA-8f for guix-devel@gnu.org; Thu, 14 Jan 2021 17:08:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60891) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0AnF-0000R5-9s; Thu, 14 Jan 2021 17:08:37 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=53444 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0AnD-0001rz-Ty; Thu, 14 Jan 2021 17:08:36 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jan Nieuwenhuizen Subject: Re: 04/06: services: hurd-vm: Avoid circular dependency with (gnu system images hurd). References: <20201207114951.24738.95603@vcs0.savannah.gnu.org> <20201207114953.D97D220CEB@vcs0.savannah.gnu.org> <87turqwfea.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 =?utf-8?Q?Niv=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 14 Jan 2021 23:08:34 +0100 In-Reply-To: <87turqwfea.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 09 Jan 2021 11:53:01 +0100") Message-ID: <877dof189p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 85FBB9402AF X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3RtnWl9fp0AV Hi, Jan Nieuwenhuizen skribis: > On current master, the disk-size setting on a childhurd has no effect, > leaving very little disk space to do development. > > I am suspecting this commit > >> commit 859b362f81598830d7ff276b96a8724aee3c4db7 >> Author: Ludovic Court=C3=A8s >> AuthorDate: Mon Dec 7 12:38:25 2020 +0100 >> >> services: hurd-vm: Avoid circular dependency with (gnu system images= hurd). >>=20=20=20=20=20 >> * gnu/services/virtualization.scm (hurd-vm-disk-image): Use >> 'lookup-image-type-by-name' instead of referring to 'hurd-disk-image' >> from (gnu system images hurd). >> --- >> gnu/services/virtualization.scm | 15 ++++++--------- >> 1 file changed, 6 insertions(+), 9 deletions(-) >> >> diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualizati= on.scm >> index eaf0bbd..f435630 100644 >> --- a/gnu/services/virtualization.scm >> +++ b/gnu/services/virtualization.scm > > [..] > >> @@ -913,14 +912,12 @@ that will be listening to receive secret keys on p= ort 1004, TCP." >> (define (hurd-vm-disk-image config) >> "Return a disk-image for the Hurd according to CONFIG. The secret-se= rvice >> is added to the OS specified in CONFIG." >> - (let ((os (secret-service-operating-system (hurd-vm-configuration-os = config))) >> - (disk-size (hurd-vm-configuration-disk-size config))) >> - (system-image >> - (image >> - (inherit hurd-disk-image) >> - (format 'compressed-qcow2) >> - (size disk-size) >> - (operating-system os))))) > > This system-image included (size disk-size), and here > >> + (let* ((os (secret-service-operating-system >> + (hurd-vm-configuration-os config))) >> + (disk-size (hurd-vm-configuration-disk-size config)) >> + (type (lookup-image-type-by-name 'hurd-qcow2)) >> + (os->image (image-type-constructor type))) >> + (system-image (os->image os)))) > > disk-size goes unused. Oops, my bad; thanks for catching it! Ludo=E2=80=99.