From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8OewK28MiGD6hwAAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 15:06:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gMlhJ28MiGDaWAAAB5/wlQ (envelope-from ) for ; Tue, 27 Apr 2021 13:06:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3F7EA8082 for ; Tue, 27 Apr 2021 15:06:55 +0200 (CEST) Received: from localhost ([::1]:55760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbNQU-0008BY-Aq for larch@yhetil.org; Tue, 27 Apr 2021 09:06:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbNQA-0008Ap-Fb for guix-devel@gnu.org; Tue, 27 Apr 2021 09:06:35 -0400 Received: from mout01.posteo.de ([185.67.36.65]:49971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbNQ5-0005AI-0N for guix-devel@gnu.org; Tue, 27 Apr 2021 09:06:34 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id D2BDE240026 for ; Tue, 27 Apr 2021 15:06:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1619528783; bh=81FPDaU/zNOh/MvzjDnngAlPUeTYmrK7qMOqxnuayko=; h=From:To:Cc:Subject:Date:From; b=qGm2L7rXBd6ezwqFA7xazf0p5Xl19TppL3hGTQL8UhCABPb62Fr2skNvVDE5PKlqz CdqQiLQ10QQU165EcJpC6Ugr7Ce464hoBV7uEmliZaPojBQ5xIbwu8UBxt4I1Q/1r6 8XJAG/YLIPlABl/SP7rGpqZ0mOnWnEKKJEgE504XVq+MfupPht1/4hpZOFJCYmYsoh HS7qTllW9W2sZjRugYyIunez98bZ7bXz9KCIaU/n5qZb/Wghw1niKYVHVKOsY/zbOi 5dMvHU9rMcSdm5aYPn0TgFstDtMe9QQg5ysg0CMNwgLr5dBOF7SO9S7CNv8AU5+yjY dX89K0p0BYBsw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FV2846nsGz9rxV; Tue, 27 Apr 2021 15:06:12 +0200 (CEST) References: <20210427113731.13295.67045@vcs0.savannah.gnu.org> <87fszbsz35.fsf@nckx> From: Guillaume Le Vaillant To: Tobias Geerinckx-Rice Subject: Re: branch master updated: gnu: Add html2text. In-reply-to: <87fszbsz35.fsf@nckx> Date: Tue, 27 Apr 2021 13:06:10 +0000 Message-ID: <877dknev25.fsf@yamatai> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=185.67.36.65; envelope-from=glv@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619528815; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HUjf6XA1NVNMbTlZKNzqIOgJe10ZfQqoIDx6ift6m8w=; b=AHoM+t3aZuCSZ2eRTr+boJstSYT0x4PxMkNbRVO/enSlC+zZHojXHhItoBluSXVlDaF8Ms 7tJW2bESYMnKSs10y3ibkQmeuK2VDnnAu8/dmv2R2xKKzOn/mFXeB28wmwoG1JJ65+4pJN tfntq4f3EK75LTadhm9AYciKA4cCPR0dLeQ+9a+qP48+7srwx3MfcwEhNG+dhvQXCMxJ5z yAXEsgTZHZxE1jYFT4zYoE1W1L7fE8auGUwDF64prQlLriuKX5f3ESyyLlCr8vqNevqUs5 AaiFtvJucHzD4wqh7V0NXwrDnWd9JaKFvlXQOC4RS5rjzNWyc2bYuow9Uhp5Xw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619528815; a=rsa-sha256; cv=none; b=MT5pcFRjrHj5aQUFqwt4N671GMuZepE++9gVyOKg0/yz/G03Q/6M0LLdARKv1VUpT9qIgd FR+knVX0jQkn/Y2sFLJqswBwJmDzzo6u/dJk7B+Fw7PuYID6dGcRtjVHU1zDFv8nsh6F/q d8sjhdzw+baibsq0+U3/4XTVWUh+d3SO2yL6IMRMOG6Gbm6mFzAkN4uDWiHcJF8O0Ib7J+ 576RPPAIjy/VmprpfAUdPQK6wFKPJwDDd/nVueRruwEhlqS14Ub2FUQBkreOF+dzPex0ls PoBmxll/ipMn7PEL0IJl51vxmXqMnsbuk+j4SqAg5E4vIymRr1RBUSJTv5GhKA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=qGm2L7rX; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -5.39 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=qGm2L7rX; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 3F7EA8082 X-Spam-Score: -5.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: 7FFKySbI6vpy --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice skribis: > Guillaume, > > guix-commits@gnu.org =E5=86=99=E9=81=93=EF=BC=9A >> gnu: Add html2text. > > Thanks! > > This package is good but would've benefited from review. Please submit a= ll > non-trivial patches to guix-patches@gnu.org first (if you did, I couldn't= find > it). We've been too lax about this in the past, myself certainly include= d. This package looked pretty simple to me, I just had to change the installation directory. > I've pushed some additional fixes[0]: > > - The configure script is home-grown and simply =E2=80=98eval=E2=80=99s a= ll command-line > arguments in the hope that they are variable assignments. Our defaults > confuse it greatly: > > --8<---------------cut here---------------start------------->8--- > configure flags: > ("CONFIG_SHELL=3D/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal= -5.0.16/bin/bash"=20 > "SHELL=3D/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/= bin/bash" > "--prefix=3D/gnu/store/bblcx4gcchp7a5dp2y51wbmlh0212xz6-html2text-2.0.1_p= re-1.05364c1"=20 > "--enable-fast-install" "--build=3Dx86_64-unknown-linux-gnu") > ./configure: line 25: eval: --: invalid option > eval: usage: eval [arg ...] > ./configure: line 25: eval: --: invalid option > eval: usage: eval [arg ...] > --8<---------------cut here---------------end--------------->8--- > > Upstream didn't bother to add error checking, but we should still call it= in > the expected manner. > > - Use #:make-flags etc. whenever possible rather than patching build sc= ripts. Ok. > - Cross-compilation was broken. Building with --target=3Daarch64-linux= -gnu > produced an x86_64 binary. Fixed by passing CXX to ./configure in the > non-standard manner above. I didn't notice that the binary produced by the cross-compilation had the wrong architecture. Good catch. > - I noticed some 4-clause BSD headers & added them to the license field. > This is purely informative: the result remains GPL2+. Ok. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYIgMQg8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j98kAD8DsK6AURafgwOUPAb6l1mt5AILuAykyqREco5 qFM00LQBAJvzO7PfF7cKdcvBEfZPxmdC5MovbOwZFuDzwNQunSSo =XqhE -----END PGP SIGNATURE----- --=-=-=--