Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Guillaume,
>
> guix-commits@gnu.org 写道：
>> gnu: Add html2text.
>
> Thanks!
>
> This package is good but would've benefited from review.  Please submit all
> non-trivial patches to guix-patches@gnu.org first (if you did, I couldn't find
> it).  We've been too lax about this in the past, myself certainly included.

This package looked pretty simple to me, I just had to change the
installation directory.


> I've pushed some additional fixes[0]:
>
> - The configure script is home-grown and simply ‘eval’s all   command-line
>  arguments in the hope that they are variable   assignments.  Our defaults
> confuse it greatly:
>
> --8<---------------cut here---------------start------------->8---
> configure flags:
> ("CONFIG_SHELL=/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash" 
> "SHELL=/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash"
> "--prefix=/gnu/store/bblcx4gcchp7a5dp2y51wbmlh0212xz6-html2text-2.0.1_pre-1.05364c1" 
> "--enable-fast-install" "--build=x86_64-unknown-linux-gnu")
> ./configure: line 25: eval: --: invalid option
> eval: usage: eval [arg ...]
> ./configure: line 25: eval: --: invalid option
> eval: usage: eval [arg ...]
> --8<---------------cut here---------------end--------------->8---
>
> Upstream didn't bother to add error checking, but we should still call it in
> the expected manner.
>
> - Use #:make-flags etc. whenever possible rather than patching   build scripts.

Ok.


> - Cross-compilation was broken.  Building with   --target=aarch64-linux-gnu
>  produced an x86_64 binary.  Fixed by   passing CXX to ./configure in the
> non-standard manner above.

I didn't notice that the binary produced by the cross-compilation had
the wrong architecture. Good catch.


> - I noticed some 4-clause BSD headers & added them to the license   field.
>  This is purely informative: the result remains GPL2+.

Ok.