From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iFURJeIYd2J5JwAAbAwnHQ (envelope-from ) for ; Sun, 08 May 2022 03:12:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CP4vJOIYd2JsKgAAG6o9tA (envelope-from ) for ; Sun, 08 May 2022 03:12:02 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 51AE840383 for ; Sun, 8 May 2022 03:12:02 +0200 (CEST) Received: from localhost ([::1]:58028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnVSr-00030f-Bi for larch@yhetil.org; Sat, 07 May 2022 21:12:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnVSS-00030Q-1i for guix-devel@gnu.org; Sat, 07 May 2022 21:11:36 -0400 Received: from mx.kolabnow.com ([212.103.80.154]:31866) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnVSM-0008WH-Pr; Sat, 07 May 2022 21:11:34 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 1B1B3CFF; Sun, 8 May 2022 03:11:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1651972283; x=1653786684; bh=0HKRGyt9zJvuCD2QoEG/y0T6/nccAYxW1wR jWc1ez10=; b=eBatFp8kkuZ99n4whSCwF1k+PHPO+U8s4rzJdyNkZWKyVfVQ+Ux RF2GExPrcrxzuRtDM7xh2yLlpWY3SoBOCuEDe61i3XPma1NgGmiNgV2MqRwBRSt+ F4gSWa9NYnU+ft9zsWatuwi60zy/mh67/0mxiFqTwAuBJMooqjqq8TysLhe8N95O bv0l6yEfXx7M6P2D9BSxCqTBHEhelEvfd2Eszl5LqIRWuE9cFN4N/nw1xZzZpRNI dR3wm+lsYrlswNv/M2nZSXniUIXwpe53d1muoz2EgCnV96Age8Qt8WFK3AdQ9A9g c//9Nz1RZ+8TWihLlC/nQ0OyzhZ+NDgJlPa01dEqFHAnlbo6nRQ3jk8AuH00snwm 3kNgxb8p6vJiFvIW0ybtig03J+krOe0b8akNAabbQD22ivc0cC4bRHVibTe92e5q aG4JDMxYU0/Pfi0Kuo4BuE6iBTdky6TlIrbaEPYBTn8yEZ+uEwBwDavvExQFQcZe WnuZiPE3raXR/sfA7GksJJeSb7F3wJ9O8OOgH9GxWCnE1Acn3oXfFhXjnEI3CsXN wkxSkgHWw5dISR6YETfSJe3XX+2HDFBkkJa/F/H241nXz33sTGwU0Gat72d4hai2 5p8ICyn/cRClQfUqZdpW+nuRLy0Qpp6p3RfbKHC2TLcX8GmJ5o+qxdWA= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wukMQa8E2eMD; Sun, 8 May 2022 03:11:23 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id 95CA4C9E; Sun, 8 May 2022 03:11:22 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx002.mykolab.com (Postfix) with ESMTPS id B62503E27; Sun, 8 May 2022 03:11:20 +0200 (CEST) References: <87h76l8yp5.fsf@systemreboot.net> <86ee1j2g8l.fsf@gmail.com> <87h76e4w2d.fsf@systemreboot.net> <8735hs9qb2.fsf@gmail.com> <871qxacp8j.fsf@kolabnow.com> <875yml916w.fsf@gmail.com> <87o80cvjdl.fsf@kyleam.com> <877d70wtd7.fsf@kolabnow.com> <87tua4jax8.fsf@gmail.com> <8735hl0yud.fsf@gnu.org> From: Thiago Jung Bauermann To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Maxim Cournoyer , Kyle Meyer , zimoun , Arun Isaac , guix-devel@gnu.org Subject: Re: Updating mumi on berlin Date: Sat, 07 May 2022 22:00:46 -0300 In-reply-to: <8735hl0yud.fsf@gnu.org> Message-ID: <877d6w96by.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.103.80.154; envelope-from=bauermann@kolabnow.com; helo=mx.kolabnow.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651972322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=0HKRGyt9zJvuCD2QoEG/y0T6/nccAYxW1wRjWc1ez10=; b=hAgUWNfOHgUvgOzl1ddcgleHNhWdONzi0wN3gqIiv0ZAshmvo/Mjcl+OnpONLX3f8poK1w cbI5RGLyrhE2ga2Mwh2r35WAvpmZAMZ3oGzBXMLM5w/gvAiDKz0SLrS3l+cQPEC1ZKFLDF iLz66rOlJ1j+ARkWLO38Yo4FauaeuPY2x/ZAGw812oaj0Y0Hoga0PBZJMoweqqtKRZsud8 9aoUP7rwNdQw9j5HZ/E1gXaUrDzC42vS4yRMCHxR3XjT6+QFvr4ltB4EBOX4opW3SqS1wA kyu345u0abtJh8dW1nXMNHaxeheoewdo4GlarHpk83vt74zeptJfu/GaAAxW8A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651972322; a=rsa-sha256; cv=none; b=rGM0SLq1wgC0qno4YvNmwoDitmB1saIg/dNu5KG5UnJs9h1ifPCl8ANk8CTvTis5p5sg8R 0xo8sYNikNA6xrM0SBjOTu1uT/24EOtx+Krdhgj+XHXFrN6ETIVtfY+2fGPvCF3GWvtj5L 3TvxY/UeDHoHM7z5hACyt6UCIMc1+hmfLPKMZ22LkvGWQnXRpuYTslwCAfhaz0aaC80wOS GHqyU6CGBp/RtZqHYQr+PB0BjUFf226Zl8j6v0rrYfyV6D1I2ajz7OZrMOQHbeiyOgpHKj dmaWdaqVq3yC+SbxwYdxM1VWRJ8O/UTIS+YMh5GQbeT+cRbS0BgMHFkoLFxVkg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=eBatFp8k; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.80 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kolabnow.com header.s=dkim20160331 header.b=eBatFp8k; dmarc=pass (policy=quarantine) header.from=kolabnow.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 51AE840383 X-Spam-Score: -4.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: jd0bGbwO+HF2 Hello, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Yes, that would be the correct and general solution (I hope you get to >> fix it, else I may look into it in some time). Workarounds currently in >> use can be seen in our mutter package definition (it's a bit convoluted, >> having to fork a process in which we set the child reaping property and >> invoke the test suite via tini, acting as a fake PID 1). > > The Guile process running the build script (with the build phases) runs > as PID 1. So how about doing one of these: > > 1. Add a final phase that does (waitpid WAIT_ANY). > > 2. Add a SIGCHLD handler that calls =E2=80=98waitpid=E2=80=99. > > I suspect the former is enough. I don't think it is, unless I'm misunderstanding something. The testsuite expects the daemon to die within a few seconds of sending it the quit command (which it does several times over the course of a number of the tests), so having it reaped at the end of the build process won't help. I tried the latter a couple of weeks ago and it didn't work either, though it's highly likely that I did something wrong in my Scheme code. I also didn't use the 1-second timer hack so perhaps that was it. I just tested this (adapted from the mutter package) and it worked: --8<---------------cut here---------------start------------->8--- @@ -4137,6 +4142,26 @@ (define-public public-inbox ;; the builder. (substitute* "t/httpd-unix.t" (("^SKIP: \\{") "SKIP: { skip('Guix');")))) + (replace 'check + (lambda* (#:key target + (tests? (not target)) (test-flags '()) + #:allow-other-keys) + (if tests? + (match (primitive-fork) + (0 ;child process + (set-child-subreaper!) + ;; Use tini so that signals are properly handled and + ;; doubly-forked processes get reaped; otherwise, + ;; lei-daemon is kept as a zombie and the testsuite + ;; fails thinking that it didn't quit as it should. + (apply execlp "tini" "--" + "make" "check" test-flags)) + (pid + (match (waitpid pid) + ((_ . status) + (unless (zero? status) + (error "`./Build test' exited with status" status= )))))) + (format #t "test suite not run~%")))) (add-after 'install 'wrap-programs (lambda* (#:key inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out"))) --8<---------------cut here---------------end--------------->8--- > Eventually, we should do one of these in gnu-build-system.scm, as in: > > https://issues.guix.gnu.org/30948#2 > > WDYT? I agree, possibly with the 1-second timer hack as well. --=20 Thanks Thiago