From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AOs1Au7m92OGpQAAbAwnHQ (envelope-from ) for ; Thu, 23 Feb 2023 23:21:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IK9SAe7m92NURgEAG6o9tA (envelope-from ) for ; Thu, 23 Feb 2023 23:21:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C61B16651 for ; Thu, 23 Feb 2023 23:21:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVJxX-0005tp-DT; Thu, 23 Feb 2023 17:21:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVJxV-0005tJ-BQ for guix-devel@gnu.org; Thu, 23 Feb 2023 17:21:01 -0500 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVJxT-0007oC-La; Thu, 23 Feb 2023 17:21:00 -0500 Received: by mail-qv1-xf35.google.com with SMTP id nv15so12372249qvb.7; Thu, 23 Feb 2023 14:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=PEGOlAlxY6EgEADqAPI7OiL5qijWIQSuql/Pmu02S+I=; b=F+IIW21h+DqIFxSAr6nIcQzDYK+UKKxfg7NA31O7Yp0XC+NFRr+zaKIAK9qXgvECDK 3QqmuwiPc25kCHZzfb+FvhVD5tPo/NB7QHu/ntEBz93mT+KCJ05kC52vNztDeukg1+KL 9PX2xwY5NaiPbk7glpOC2O/TYe3Bk1ylCJpJAncpF2qjRhvBRCYRQzwunuYMoSDUnPfj +kDniS3LhAr+zHW/y9pxvbJwlVrieGaPhS+mXrweFDDSQHYL/YnCrtI/41Y3tK8T+Hvm n/6erQjlHdgWnEZstYBpQeAUmFSrmxBbpWdU9T09YSFpmF/5+mXk1otN0ZOiQaq6hShG 2brg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PEGOlAlxY6EgEADqAPI7OiL5qijWIQSuql/Pmu02S+I=; b=OT3JWS+tl6py5iTVkupV0ZAlVtgbccRBCPFPIqqbEfIMgwo6cNgO25wnfEkX23yG53 616TSXoIaJv+bz134bfbDyfqeBQKh46coVIQKuOaamRc0VjDFLVjc7LF+IbROtYBv3uC HJAys+z3gMAN0sUllDktT8Ilv9Q4tbiUKgfuWudqHNC6h1SMTkRA1rn+8TeLWq+3Ajkf 37NpxgS/MDJG4w+Fx3EsRir0HRKAH0LC9EoFrZkDUirT9w7mQSlXEIRKHeOWaQz3KQ9h 7pE8nvi1GSwIEVc/GXd7ijj11kd2h2l7wc6U3oOkMjVbYovo5+JPnk8mhdlwS+c7f5Ia 6QmA== X-Gm-Message-State: AO0yUKWECFJQkj5/Uncw3Dn4yBLeiS5wCyvm1C7USJnUK5q3zArJijdt YCWAQ605oa3uFscEgj/gwZeEVRvQAFSaqw== X-Google-Smtp-Source: AK7set+c4HZUIFnVPsHVqugFBGO6dWy2OuSeS6hUlMCnUSy+6S+LZxLHnec2hn7dPy7MSNaKgGfUBg== X-Received: by 2002:a05:6214:2529:b0:56e:aa11:da91 with SMTP id gg9-20020a056214252900b0056eaa11da91mr23362439qvb.14.1677190857027; Thu, 23 Feb 2023 14:20:57 -0800 (PST) Received: from hurd (dsl-10-129-1.b2b2c.ca. [72.10.129.1]) by smtp.gmail.com with ESMTPSA id q205-20020a3743d6000000b0073b75718428sm5331045qka.134.2023.02.23.14.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 14:20:56 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel Subject: Feedback on indentation rules (was: [PATCH 0/5] Add support for the RPM format to "guix pack") References: <20230203221409.15886-2-maxim.cournoyer@gmail.com> <20230203221409.15886-5-maxim.cournoyer@gmail.com> <87357alp9n.fsf_-_@gnu.org> <878rgxws6l.fsf@gmail.com> <871qmg5qpj.fsf@gnu.org> Date: Thu, 23 Feb 2023 17:20:55 -0500 In-Reply-To: <871qmg5qpj.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 23 Feb 2023 16:47:20 +0100") Message-ID: <877cw8hvlk.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f35; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=F+IIW21h; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677190893; a=rsa-sha256; cv=none; b=M5T/zro/S6ZVkjYJUFBxriQfnAUccXsLFrQWHYQOzNBISfSlZ5B1lFS6B0mM1vxFx06i+A DI9GsTogHDV4H82CiJbcVjjVwIE5lPhVTYkJnBstMx9hE7WhFg0hprE5b5uzbRFwbZQjD3 sgT2wBJbGT4zc8KWb8r2gCCN3t4F/qO46LsuId3SyZPh3gAAZeWHaJyKQNQaxuwAtEhKRV 3uyGkMY8aiSTrtp8cDyCr+Cvh3piDHJiTGDq4McQcGh0EW78Y1gD/UZky4hnhVtJKDQJ1Q vKlgnxi92Ewu7ctQTD5G3ZQyNlqVKOo92QpP8q1W2J44KP9egCR/F7WvA5yNkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677190893; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=PEGOlAlxY6EgEADqAPI7OiL5qijWIQSuql/Pmu02S+I=; b=Nt6c9Gx1GtVHBGqBHvUHuBt4+PoWyG4zVkSVVo0wTTuoO1E2nLqfXGoKt+kH5tPFVZaGwB VoY7UZ4Nx6StDqgIhDlKO+pCfVqhpj5B8KM+v2RcIB7C/SgPbHCIcLfxghZZCU7ZJH1Ddv FLQcLHrl9B4Kns/rUZO2uX9IO0xF3X7N0SFT/o7ZACcxYq04y1IhG4ReNAAMii8taPabmK eVsWDKJDwbsqVcxlGLDhWJyeHnKWV1RQMciq1GxzUw0qvrgjjU4tCvZ6VfzERrfUrsMuR6 IaEaD+OrYLuqA/z//DtgZVeC4FfNdJ1t1lsJBT4WKRXbXk2Db1UoozQLzqisEQ== X-Migadu-Spam-Score: -6.39 X-Spam-Score: -6.39 X-Migadu-Queue-Id: C61B16651 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=F+IIW21h; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com X-TUID: yhwVXVQy0Stw -CC bug#61255 +CC guix-devel Hi Ludovic and guix-devel readers, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: >> [...] >>> I=E2=80=99m not convinced by the indentation rule for =E2=80=98gexp->de= rivation=E2=80=99 added >>> in 82daab42811a2e3c7684ebdf12af75ff0fa67b99: there=E2=80=99s no reason = to treat >>> =E2=80=98gexp->derivation=E2=80=99 differently from other procedures. >> >> The benefit I saw was that writing >> >> (gexp->derivation the-name >> #~(begin >> (the >> (multi-line >> (gexp))))) > > I understand, but you know, it=E2=80=99s best to avoid unilaterally chang= ing > established conventions. :-) > > If and when there=E2=80=99s consensus about this change, (guix read-print) > should be updated. OK. I'm not against soliciting more opinions; I'm CC'ing guix-devel, hoping some opinionated individuals tip in on this 2021 82daab42811a2e3c7684ebdf12af75ff0fa67b99 commit, more specifically, the part that change the indentation rules for .dir-locals.el like this: --8<---------------cut here---------------start------------->8--- + (eval . (put 'gexp->derivation 'scheme-indent-function 1)) --8<---------------cut here---------------end--------------->8--- In the same spirit there was also b1c25e2ce364741d1c257d3bb3ab773032807a80 (".dir-locals.el: Add indentation rule for computed-file.") made more recently (last month). The idea was to be able to format gexp->derivation like this: --8<---------------cut here---------------start------------->8--- (gexp->derivation "check-deb-pack" (with-imported-modules '((guix build utils)) #~(begin (use-modules (guix build utils) (ice-9 match) (ice-9 popen) (ice-9 rdelim) (ice-9 textual-ports) (rnrs base)) [...] --8<---------------cut here---------------end--------------->8--- Rather than like this: --8<---------------cut here---------------start------------->8--- (gexp->derivation "check-deb-pack" (with-imported-modules '((guix build utils)) #~(begin (use-modules (guix build utils) (ice-9 match) (ice-9 popen) (ice-9 rdelim) (ice-9 textual-ports) (rnrs base)) --8<---------------cut here---------------end--------------->8--- (or having to use another 'builder' variable, for example). What do you all think? --=20 Thanks, Maxim