From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SBN/JRWir2T9OQAASxT56A (envelope-from ) for ; Thu, 13 Jul 2023 09:04:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gMGeJBWir2TF5wAAG6o9tA (envelope-from ) for ; Thu, 13 Jul 2023 09:04:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A7FF4F3BE for ; Thu, 13 Jul 2023 09:04:53 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=bI5xFDfs; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689231893; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=hY6xXW1CRMcI5mhvKyQg6FhB1RbTXsCHdKSIVjkx5q8=; b=E/iiWdHwpacePYWRePSUDRWclqHd4GhwrS3FDg7+tSaeKNyauXL/1FyQljAGUnMhyVEy3l Azzr8SMOWNm5KTVOUCBE9KzjPE+R99qw26DbSeZ/BWdvkIgCilOzeM35bUbv1JOopD7xkP qDIv3DHR1gfJn9lUydXF3W+/RgFTAdT3FUknmFJEWhKG7lYvjGvft86g2lqkLz+tS3+GGt LhZSEHZakVU7STnm9sPPFuRjl1VybzelF9mjHNzhFJR0gAxVhMFb1jvwMSotKTnNGEh6mZ 3YdueCSuAmA8FNanWoSJbAqW6i5LQgwyKlHdjZR9Js7MQps+d0KZHCgGe4nBFw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=elephly.net header.s=zoho header.b=bI5xFDfs; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=2; s=key1; d=yhetil.org; t=1689231893; a=rsa-sha256; cv=pass; b=VdCgFpRiNbB2+gH9An6Tbmu+8C/HAOyxlogfbKxM8HxVNeC0sbNz75RcnwOb5jiwwQDrkE GJYTxWSYcy4TKGXc9kFuOp60p1AbBtWx6B0W0uKiTC+9qkClboYF6JLRKqeHFlIjI8Q8Of 7CYuXDjeGtNFdY+LhSoX/Aq5UTjnbuHK8DdQO9101ZzVLIfy8LoSTd04euSF0PvQcayaZj rXjy1f+XvFGVGW3xrYmgnAIg7djN1eY6guq6fjjtK/UaN1a8Ry6qPzu+5OlJCYYfiQV19c y0hqtKInpCzyXdpWemytZaa7G4d0po1TkEkzcqDuNzg5EihyMevtTgaGIZWzBw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJq9v-0003Mm-Tx; Thu, 13 Jul 2023 02:50:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJq9r-0003KH-6K for guix-devel@gnu.org; Thu, 13 Jul 2023 02:50:35 -0400 Received: from sender3-of-o57.zoho.com ([136.143.184.57]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJq9p-00042J-7i for guix-devel@gnu.org; Thu, 13 Jul 2023 02:50:34 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1689231029; cv=none; d=zohomail.com; s=zohoarc; b=hfTULvIw7HD6aD9BiI4mjB4vJ/41te+noSx0RcTyRSRJ/at8H92hGfhzbhpkzcAjLzKaoBaik/08BFd0VOXFy5OKzoC7Y5KLi6pXdRyJYcYFAez9AZmMtYBK9oimO/kx/MOnx1cafiYXPuRvHApGkhhMAvyYdqKj/oPfILZUhG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689231029; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=hY6xXW1CRMcI5mhvKyQg6FhB1RbTXsCHdKSIVjkx5q8=; b=KC9CVDYwL7Y/2FUkxYihqH5FEaXMzOlP2JAYPSreGnne+lMCiavZXz4VcOpC/5AddjdBR0u4qR4W2LulNT+IL/ncx5tp8YENuanBzAjGAuuHbEJhWJlnIL+IvyfMd+BrTSVWYi1eW0tR2vdIZ9vNOkQ6VP9dWwaDHOwbeBfywXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689231029; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=hY6xXW1CRMcI5mhvKyQg6FhB1RbTXsCHdKSIVjkx5q8=; b=bI5xFDfsD7ealEnP6taNPEfT/yaZ9Z4y1BfhrTooXqOEU0abkyneYIncU0IqPj7o +oExHTzgycbCSkxFIx/JzhA1tji+Pc71n18Cg6832wy3cnhCOARYmTEatVrzR19pZup ywBZQO1lxjhTgU+TERhWaJYxGb8ITs88gX66ZN08= Received: from localhost (215-111-142-46.pool.kielnet.net [46.142.111.215]) by mx.zohomail.com with SMTPS id 1689231026709411.61118353420204; Wed, 12 Jul 2023 23:50:26 -0700 (PDT) References: <873520tgi4.fsf@elephly.net> <87sf9z5221.fsf@fsfe.org> User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus To: Jelle Licht Cc: guix-devel@gnu.org Subject: Re: npm has irreproducible install behavior Date: Thu, 13 Jul 2023 08:48:13 +0200 In-reply-to: <87sf9z5221.fsf@fsfe.org> Message-ID: <877cr4i9u8.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.57; envelope-from=rekado@elephly.net; helo=sender3-of-o57.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 4A7FF4F3BE X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -10.04 X-Spam-Score: -10.04 X-TUID: 80GHlRDrdoZh Hi Jelle, >> I=E2=80=99ve tested this little addition to the build phases of node-lts= on an >> affected system: >> >> --8<---------------cut here---------------start------------->8--- >> (add-after 'install 'do-not-ignore-links >> (lambda* (#:key outputs #:allow-other-keys) >> (with-directory-excursion >> (string-append (assoc-ref outputs "out") >> "/lib/node_modules/npm/node_modules") >> (substitute* "pacote/lib/fetcher.js" >> (("\\/Link\\$\\/.test\\(entry.type\\)") "f= alse") >> (("\\/File\\$\\/.test\\(entry.type\\)") >> "/(File|Link)$/.test(entry.type)")) >> --8<---------------cut here---------------end--------------->8--- > > The proposed change seems fine to me, provided our QA shows a pretty > green button at some point. Could you send a patch that also includes a > comment referencing the upstream bug report? I changed it to patch node-tar instead, because the patch to fetcher.js would cause *some* files to be copied to the wrong location. I=E2=80=99ll send the updated patch to guix-patches today. --=20 Ricardo