From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6INxNpN3AmXbRgAA9RJhRA:P1 (envelope-from ) for ; Thu, 14 Sep 2023 05:01:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6INxNpN3AmXbRgAA9RJhRA (envelope-from ) for ; Thu, 14 Sep 2023 05:01:39 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6CCFF43C3C for ; Thu, 14 Sep 2023 05:01:39 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="ksSvC/n/"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694660499; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=p/wsRxBvrej03OWf6G5uPf6gShWdbmv4CENJQpftGgA=; b=WtmJQq+0DRiH7Ams9Ckxxx2GgkpIQz6Tlux+zfCCHizoAv75X8kor6EwCNFxKki7f+Z244 ot3JMEMf31srPpDWeLG4UcbBcTRip5wsm0+wbFOdxX29bxUo8j8Y4VPhMV/3jJX1W87dN4 DRikajC5x9D6dVAne0wCqxEgfD3L2TYCX11kRcblcYqNVn9pS5FnV6nGxtOsj1N0EWyjOV 06WYr0gOGEBa128bsf1VwMpij4vmWom0bgWyVy5S1/pCS4IWmYfXX8n4HOi6h2NjmUSfLd b8hxjJ1aIAQqIGLslplm0fizg4EpZCY1SDFkyuq9sGajRoX8WpVjeBAGlkFXMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="ksSvC/n/"; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694660499; a=rsa-sha256; cv=none; b=G94w9jrvEuD0/0jkdCd1SwOx8Mcozi54Punxqa0dBALGfxZPAc5pt3ZrhozpO50nSkPtD6 tqiXUkIPY9sbdF8ue2Gkp4o9+bew+gmBA2aCT6QCRiaX+1h0vBYT1e3emlDynbmSTJyAFi Srl3SYNIFeVFDPoWVsR6gOdDPDhS/I7yKgTeXQOCsyRiR3vI699gMCB9I1w2U6AywT/utD Cbdz03ciPX4POfA9w4CVcuMlieLNejvnDqgmdFNYervNqBT5bPjKG6fh1ZrsFloWV/Q0BK na7oAMKL2AQGy7/pw4c7/Tixmhqqstm7Ldza0w/EdyPUpcXS66m3siDLf6EMEA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgcbB-0001xp-G7; Wed, 13 Sep 2023 23:00:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgcb4-0001t9-4r for guix-devel@gnu.org; Wed, 13 Sep 2023 23:00:50 -0400 Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgcb1-00058F-To; Wed, 13 Sep 2023 23:00:49 -0400 Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-655d25f3678so3195606d6.3; Wed, 13 Sep 2023 20:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694660445; x=1695265245; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=p/wsRxBvrej03OWf6G5uPf6gShWdbmv4CENJQpftGgA=; b=ksSvC/n/qUvIFkcEzcObq5Zcl/V+DIx6qV+pUazm3tXK3FO3yENIfxT4iePDFrLUC+ Tj5D2zq1UFaO4ADRGFbcV7nc5wljV4Tlz0wCoF/PoVtv0HknU/fiEgbIxT1ySln0iIZ8 sj7to8Omzn86Zlx+p4FdnT5NDwW5H7cZD+iKdJ2Mmyhk8gZUcR0Cg9rF23ojOC6L37FK YOIAQHKAN7m25+8mop0KYBN8CUYhChkb3vwd5543TK3iAe4CEELxid1QXa9dcZsYrw6V cQbMckUdiic+ozjPJpPZQ1c0l0dtIk5g3+Nsy+1WTNvCB8uiSn7IG/9BTWf05nBhc0vr 3M2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694660445; x=1695265245; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=p/wsRxBvrej03OWf6G5uPf6gShWdbmv4CENJQpftGgA=; b=n276mUXj75KqU8fI1ddMsS0n5+rP1azI/B3oy8MQQOiEBYxwIHnAyJD4eXSx/FBM8y SrLFSmrhFIvejs4yv1o/3Uxzt21H9jx89cOfLSNVrNrfSOIVf1PRGMOR3NrvluHLo0MF Ys4WCTKUSLiVzLVll5/N35FsobYWwwZW+x9rUaN4vp4QgXukwUKhmC6CkPZOQX85h0oU DEJlkMibaIbaK4ozdih/0Vu3F49/wcnDylL2PEsHv6jVEZZrEG/I8Wr/OeEWgLPY1+Ch qVZghOhPWNY7MtqaD4rcNHbqFuFIPVYNL3i0ROmE1KHFUZHP0d7jxDgqSbczaYhm4rTj lFDA== X-Gm-Message-State: AOJu0YxwGUYD+u5uZtSskpl4YecwRnHD9/hu3bv9jhAvICiqOefXekd8 6sjg8KiUkpVSihosWix8boRwkQOiC8I= X-Google-Smtp-Source: AGHT+IFEeHh9ZTSznNLIQ5HUYYfD13sAlPTvy1cXoEolcT+j4xXKqwjhF0whAA30MiOkoQ/ZcuTuRQ== X-Received: by 2002:a0c:8b12:0:b0:64f:71bf:509 with SMTP id q18-20020a0c8b12000000b0064f71bf0509mr3964006qva.27.1694660444805; Wed, 13 Sep 2023 20:00:44 -0700 (PDT) Received: from hurd (dsl-149-165.b2b2c.ca. [66.158.149.165]) by smtp.gmail.com with ESMTPSA id t29-20020a0cb39d000000b0063d162a8b8bsm191894qve.19.2023.09.13.20.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 20:00:44 -0700 (PDT) From: Maxim Cournoyer To: Simon Tournier Cc: Liliana Marie Prikler , Giovanni Biscuolo , Vagrant Cascadian , guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [workflow] Automatically close bug report when a patch is committed References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> <87y1hikln6.fsf@wireframe> <2d93b48dfd381c55ff706394ff7226133f5e014a.camel@gmail.com> <87pm2pces0.fsf@xelera.eu> <87bke8wo96.fsf@gmail.com> <929b035f6f4aca0793d9f8a6454b673b2a7069c1.camel@gmail.com> <87zg1sv3vt.fsf@gmail.com> <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> <87h6nyw0su.fsf@gmail.com> <86zg1pwwmw.fsf@gmail.com> Date: Wed, 13 Sep 2023 23:00:42 -0400 In-Reply-To: <86zg1pwwmw.fsf@gmail.com> (Simon Tournier's message of "Thu, 14 Sep 2023 00:12:23 +0200") Message-ID: <877cotv4px.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f2a; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -1.11 X-Spam-Score: -1.11 X-Migadu-Queue-Id: 6CCFF43C3C X-TUID: TaJQ+1VUwhr4 Hi, Simon Tournier writes: > Hi, > > On Wed, 13 Sep 2023 at 21:14, Liliana Marie Prikler wrote: > >> I do wonder how the ChangeId would work in practice. Since it's not >> really assigned by the committer, it would have to be generated "on the >> fly" and attached to the mail in between, which could result in all >> kinds of nasty behaviour like unstable Ids or duplicated ones. Also, >> if we can automate this for ChangeIds, we could also automate this for >> patch-sets =E2=80=93 the last patch in the series just gets the Closes: = tag >> added by mumi. > > I think it would work using some pre-commit hook. When one commits > their change, this commit is run and it can pre-fill the commit > message. Well, that=E2=80=99s how I have understood the thread. Yes; exactly like how it's done in Gerrit, if you've ever used that (we'd reuse their hook). It'd be enabled out-of-the-box so it'd be transparent to users. >> Furthermore, I'm not convinced that it would ease the issue of >> forgotten bugs as you can't really apply them to the past. So the >> practical use is limited to the case where you intentionally cherry- >> pick this or that commit from a series. How we want to deal with that >> case could be a discussion in its own right, and maybe ChangeIds really >> trump the explicit tags proposed by Giovanni or myself here. Whether >> that justifies the cognitive overhead of juggling them around on every >> submission remains to be shown or disproven. I like the 'Closes: ' trailer idea; it's simple. However, it'd need to be something added locally, either the user typing it out (unlikely for most contributors) or via some mumi wizardry (it's unlikely that all users will use mumi), which means its usage (and value) would depend on how motivated individuals are to learn these new tricks. On the other hands, having Change-Ids added by a pre-commit hook automatically would means the user doesn't need to do anything special other than using git, and we could still infer useful information at any time (in a server hook, or as a batch process). For this reason, I think we could have both (why not? Change-Ids by themselves provide some value already -- traceability between our git history and guix-patches). --=20 Thanks, Maxim