From: Simon Tournier <zimon.toutoune@gmail.com>
To: Guix Devel <guix-devel@gnu.org>
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: Guile CSE elimination of record accessor?
Date: Sat, 27 Apr 2024 19:04:44 +0200 [thread overview]
Message-ID: <877cgig2j7.fsf@gmail.com> (raw)
Hi,
In Guile module (ice-9 vlist), one reads:
--8<---------------cut here---------------start------------->8---
;; Asserting that something is a vlist is actually a win if your next
;; step is to call record accessors, because that causes CSE to
;; eliminate the type checks in those accessors.
;;
(define-inlinable (assert-vlist val)
(unless (vlist? val)
(throw 'wrong-type-arg
#f
"Not a vlist: ~S"
(list val)
(list val))))
[...]
(define (vlist-head vlist)
"Return the head of VLIST."
(assert-vlist vlist)
(let ((base (vlist-base vlist))
(offset (vlist-offset vlist)))
(block-ref (block-content base) offset)))
--8<---------------cut here---------------end--------------->8---
Other said, the argument ’vlist’ is “type-checked” with ’assert-vlist’
and thus that is exploited by Guile compiler, if I understand correctly
the comment.
The first question is: is it still correct? Because this module had
been implemented before many Guile compiler improvements.
The second question, if the comment above is still valid, is: could we
also “win” for some record inside Guix source code?
Concretely, one example about the record <package>, there is some
procedures such that:
--8<---------------cut here---------------start------------->8---
(define* (package->manifest-entry package #:optional (output "out")
#:key (parent (delay #f))
(properties (default-properties package)))
"Return a manifest entry for the OUTPUT of package PACKAGE."
;; For each dependency, keep a promise pointing to its "parent" entry.
(letrec* ((deps (map (match-lambda
((label package)
(package->manifest-entry package
#:parent (delay entry)))
((label package output)
(package->manifest-entry package output
#:parent (delay entry))))
(package-propagated-inputs package)))
(entry (manifest-entry
(name (package-name package))
(version (package-version package))
(output output)
(item package)
(dependencies (delete-duplicates deps))
(search-paths
(package-transitive-native-search-paths package))
(parent parent)
(properties properties))))
entry))
--8<---------------cut here---------------end--------------->8---
which fits the comment above: a record as argument and record accessor
call.
And that could also be applied to other records, I guess.
Any answers, explanations or references are very welcome. :-)
Cheers,
simon
PS: Raining day and weird pastime… diving into Guile source code. ;-)
next reply other threads:[~2024-04-29 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 17:04 Simon Tournier [this message]
2024-04-30 14:43 ` Guile CSE elimination of record accessor? Andy Wingo
2024-05-03 18:08 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cgig2j7.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).