unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Sent <richard@freakingpenguin.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Codifying/Documenting Guix commit message conventions?
Date: Fri, 28 Jun 2024 21:42:12 -0400	[thread overview]
Message-ID: <877ce8v823.fsf@freakingpenguin.com> (raw)
In-Reply-To: <877ce8a6yh.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 28 Jun 2024 21:11:34 -0400")

Hi Maxim,

Thanks for the detailed response! (And Andreas as well)

> Another Emacs tip for those who don't know it yet: pressing 'C'
> (capital C) on a diff hunk while authoring a commit message using
> Magit will create some ChangeLog entry stub in the commit message
> buffer, which saves a lot of typing. Perhaps we should mention this in
> our doc, as it makes writing GNU ChangeLog less painful.

Bonus points, there's a magit-generate-changelog [1] function that can
be run from the commit message buffer that'll insert changelog entries
for every diff hunk. I use this snippet to bind it to the commit entry
keymap:

--8<---------------cut here---------------start------------->8---
(use-package magit
  ;; ...
  :bind (:map git-commit-mode-map
              ("C-c m" . magit-generate-changelog)))
--8<---------------cut here---------------end--------------->8---

> That sounds like a good, incremental, non-controversial approach to the
> issues found (good observation, by the way!); I encourage you to pursue
> it.

Got it, I'll take a crack at it at some point. I'll approach it from the
perspective of documenting current practices (standardizing on one
option when there are alternatives). Then if we don't like those
practices ([] vs <>), we can discuss if we should push for matching GNU
ChangeLog or leave it as is.

The joys of Texinfo await me. For some values of joy. 🙂

(If I recall correctly there's been discussion of an RFC process in the
past. I don't recall the details but depending on how expansive this
becomes perhaps that's relevant.)

[1]: https://github.com/magit/magit/pull/3928

-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.


  reply	other threads:[~2024-06-29  1:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 23:04 Codifying/Documenting Guix commit message conventions? Richard Sent
2024-06-28  8:59 ` Andreas Enge
2024-06-29  1:11 ` Maxim Cournoyer
2024-06-29  1:42   ` Richard Sent [this message]
2024-06-29  6:51   ` Liliana Marie Prikler
2024-06-30  1:11     ` Maxim Cournoyer
2024-06-30  6:25       ` Liliana Marie Prikler
2024-07-01 14:14         ` Maxim Cournoyer
2024-07-01 22:17           ` Richard Sent
2024-07-02  2:20             ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ce8v823.fsf@freakingpenguin.com \
    --to=richard@freakingpenguin.com \
    --cc=guix-devel@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).