From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] guix package: Add '--delete-generations'.
Date: Thu, 26 Sep 2013 11:49:04 +0200
Message-ID: <8761tnud4f.fsf@gnu.org>
References: <87vc2o4qwc.fsf@gnu.org> <87y57kljro.fsf@karetnikov.org>
	<87hae81uvo.fsf@gnu.org> <87li2oslzh.fsf_-_@karetnikov.org>
	<878uyo60gp.fsf@gnu.org> <877ge7onje.fsf@karetnikov.org>
	<87eh8ftuii.fsf@gnu.org> <87eh8dzg39.fsf@karetnikov.org>
	<87fvstm4q8.fsf@gnu.org> <87vc1oi9j8.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55485)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VP8Gx-00053S-GP
	for guix-devel@gnu.org; Thu, 26 Sep 2013 05:54:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VP8Gr-0005Cd-RE
	for guix-devel@gnu.org; Thu, 26 Sep 2013 05:54:11 -0400
Received: from hera.aquilenet.fr ([141.255.128.1]:33825)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VP8Gr-0005CS-Ke
	for guix-devel@gnu.org; Thu, 26 Sep 2013 05:54:05 -0400
In-Reply-To: <87vc1oi9j8.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Thu, 26 Sep 2013 06:47:23 +0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: guix-devel@gnu.org

Nikita Karetnikov <nikita@karetnikov.org> skribis:

>> Frankly, I don=E2=80=99t like it.  I think the default behavior should n=
ot be to
>> let the user shoot themself in the foot.
>
>> WDYT?
>
> OK, what about these patches?  Can I push them?
>
>
> From 86d29a8b233d5cf6549fbcddf43b185086b7d178 Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <nikita@karetnikov.org>
> Date: Wed, 25 Sep 2013 03:34:49 +0000
> Subject: [PATCH 2/3] guix package: Add 'link-to-empty-profile'.
>
> * guix/scripts/package.scm (link-to-empty-profile): New function.
>   (roll-back): Use it.

OK, please push.

> From c246f4a72ade85dffa95d7c598e24539896ca5a5 Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <nikita@karetnikov.org>
> Date: Thu, 26 Sep 2013 02:36:24 +0000
> Subject: [PATCH 3/3] guix package: Add '--delete-generations'.
>
> * guix/scripts/package.scm (switch-to-previous-generation): New function.

(Normally that part would go in a patch of its own since it=E2=80=99s
refactoring unrelated to the implementation of =E2=80=98--delete-generation=
s=E2=80=99,
but that=E2=80=99s OK for this time.)

>   (roll-back): Use the new function instead of 'switch-link'.
>   (show-help): Add '--delete-generations'.
>   (%options): Likewise.
>   (guix-package)[process-actions]: Add 'current-generation-number',
>   'display-and-delete', and 'delete-generation'.  Add support for
>   '--delete-generations', and reindent the code.
> * tests/guix-package.sh: Test '--delete-generations'.
> * doc/guix.texi (Invoking guix-package): Document '--delete-generations'.

Looks good to me, please push!

Thanks for all the work!

Ludo=E2=80=99.