unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: Cmake build system and build directories
Date: Mon, 25 Nov 2013 23:41:04 +0100	[thread overview]
Message-ID: <8761rgqf3z.fsf@gnu.org> (raw)
In-Reply-To: <20131125222201.GA14911@debian> (Andreas Enge's message of "Mon, 25 Nov 2013 23:22:01 +0100")

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Andreas Enge <andreas@enge.fr> skribis:

> CMake Error at cmake/modules/MacroEnsureOutOfSourceBuild.cmake:17 (MESSAGE):
>   kdelibs requires an out of source build.  Please create a separate build
>   directory and run 'cmake path_to_kdelibs [options]' there.
> Call Stack (most recent call first):
>   CMakeLists.txt:157 (macro_ensure_out_of_source_build)
>
> I think it is simply a matter of replacing in
>    cmake-build-system.scm (configure)
> the call to
>    cmake
> by
>    mkdir build
>    cd build
>    cmake ..
> (appropriately guilified).

I suspect this one-byte change is enough:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 539 bytes --]

diff --git a/guix/build-system/cmake.scm b/guix/build-system/cmake.scm
index e09f165..1a5f4b6 100644
--- a/guix/build-system/cmake.scm
+++ b/guix/build-system/cmake.scm
@@ -48,7 +48,7 @@
                      (search-paths '())
                      (make-flags ''())
                      (cmake (default-cmake))
-                     (out-of-source? #f)
+                     (out-of-source? #t)
                      (tests? #t)
                      (test-target "test")
                      (parallel-build? #t) (parallel-tests? #f)

[-- Attachment #3: Type: text/plain, Size: 177 bytes --]


Can you confirm?

It will cause some rebuild, but it’s probably the right thing since my
understanding is that out-of-source builds are the norm with CMake.

Ludo’.

  reply	other threads:[~2013-11-25 22:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 22:22 Cmake build system and build directories Andreas Enge
2013-11-25 22:41 ` Ludovic Courtès [this message]
2013-11-26  7:50   ` Andreas Enge
2013-11-26 15:11     ` Ludovic Courtès
2013-11-27 23:16       ` Ludovic Courtès
2013-11-27 23:40         ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761rgqf3z.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).