From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] gnu: Add octave and dependencies
Date: Sat, 25 Jan 2014 16:30:30 +0100
Message-ID: <8761p8ulih.fsf@gnu.org>
References: <1390507648-21659-1-git-send-email-jmd@gnu.org>
	<1390507648-21659-3-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38544)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W75Gn-0005Kf-Bq
	for guix-devel@gnu.org; Sat, 25 Jan 2014 10:35:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W75Gh-0000jj-VY
	for guix-devel@gnu.org; Sat, 25 Jan 2014 10:35:41 -0500
In-Reply-To: <1390507648-21659-3-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Thu, 23 Jan 2014 21:07:28 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/maths.scm (octave gnuplot): New variables

Should be =E2=80=9C(octave, gnuplot)=E2=80=9D.

> +(define-public gnuplot
> +  (package
> +    (name "gnuplot")
> +    (version "4.6.3")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "mirror://sourceforge/gnuplot/gnuplot/"
> +                                version "/gnuplot-" version ".tar.gz"))
> +      (sha256
> +       (base32
> +        "1xd7gqdhlk7k1p9yyqf9vkk811nadc7m4si0q3nb6cpv4pxglpyz"))
> +      ))

Please move the closing parens to the previous line.

> +    (build-system gnu-build-system)
> +    (home-page "http://www.gnuplot.info")
> +    (synopsis "command-line driven graphing utility.")

Start with a capital letter and remove the final period.

> +    (description "Gnuplot  is a portable command-line driven graphing
                            ^^
Extra space.
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=
=20=20=20
> +    (license=20
> +     license:fsf-free))) ; http://gnuplot.cvs.sourceforge.net/gnuplot/gn=
uplot/Copyright=20
> +                         ;  X11 Style with the additional restriction th=
at
> +                         ;  derived works may only be distributed as pat=
ches
> +                         ;  to the original.

=E2=80=98fsf-free=E2=80=99 is actually a procedure, so it should be:

  (license (license:fsf-free "http://gnuplot.cvs.sourceforge.net/gnuplot/gn=
uplot/Copyright"))

The comment should be kept just above.
> +    (native-inputs
> +     `(("gfortran" ,gfortran-4.8)
> +       ("perl" ,perl)
> +       ("less" ,less)
> +       ("pkg-config" ,pkg-config)
> +       ("texinfo" ,texinfo)
> +       ("ghostscript" ,ghostscript)
> +       ("gnuplot" ,gnuplot)))
> +    (propagated-inputs
> +      `(("texinfo" ,texinfo)
> +        ("less" ,less)
> +        ("ghostscript" ,ghostscript)
> +        ("gnuplot" ,gnuplot)))

Oh, seems like a case where native inputs need to be propagated.

Why do less, Texinfo, etc. need to be propagated?

If that=E2=80=99s because Octave expects them to be in $PATH, then maybe an
option would be to use =E2=80=98wrap-program=E2=80=99 to wrap the =E2=80=98=
octave=E2=80=99 program with
a shell script that initialize $PATH to contain these.

That way, we make sure Octave will run with the =E2=80=9Cright=E2=80=9D ver=
sions of
these (those used at compile time and known to work), and the user=E2=80=99s
environment doesn=E2=80=99t end up pulling them.

An example of =E2=80=98wrap-program=E2=80=99 is Git (in version-control.scm=
.)

Other than that, looks great to me!

Thanks!

Ludo=E2=80=99.