From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libgpg-error as propagated inputs to gnupg, gpgme, and pinentry
Date: Wed, 19 Feb 2014 22:24:04 -0500 [thread overview]
Message-ID: <8761oa8o17.fsf@netris.org> (raw)
In-Reply-To: <87ob23md40.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 19 Feb 2014 14:43:59 +0100")
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> From e6ddaf74f30ee5d6c8d76a3ae9cacdb14eb060c5 Mon Sep 17 00:00:00 2001
>> From: Mark H Weaver <mhw@netris.org>
>> Date: Tue, 18 Feb 2014 22:06:34 -0500
>> Subject: [PATCH] gnu: Add libgpg-error as propagated inputs to gnupg,
>> gpgme, and pinentry.
>>
>> * gnu/packages/gnupg.scm (gnupg, gpgme, pinentry): Make 'libgpg-error'
>> a propagated input.
>
> This makes sense for GPGME, because it’s a library and its headers may
> refer to the libgpg-error headers.
>
> But what about GnuPG and Pinentry? These are normally just end-user
> programs, right?
Indeed, my mistake.
> Also, please write a one-line rationale for the propagation as a
> comment.
Good idea. Here's an updated patch.
Thanks,
Mark
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] gnu: gpgme: Make 'libgpg-error' a propagated input --]
[-- Type: text/x-patch, Size: 1195 bytes --]
From 68640c3c09c6c9ddcaae8d50754f0876b273d42a Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Wed, 19 Feb 2014 19:20:53 -0500
Subject: [PATCH] gnu: gpgme: Make 'libgpg-error' a propagated input.
* gnu/packages/gnupg.scm (gpgme): Make 'libgpg-error' a propagated input.
---
gnu/packages/gnupg.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index 499b200..85ce076 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -226,10 +226,12 @@ components), libgpg-error (centralized GnuPG error values), and libskba
(base32
"15h429h6pd67iiv580bjmwbkadpxsdppw0xrqpcm4dvm24jc271d"))))
(build-system gnu-build-system)
+ (propagated-inputs
+ ;; Needs to be propagated because gpgme.h includes gpg-error.h.
+ `(("libgpg-error" ,libgpg-error)))
(inputs
`(("gnupg" ,gnupg)
- ("libassuan" ,libassuan)
- ("libgpg-error" ,libgpg-error)))
+ ("libassuan" ,libassuan)))
(home-page "http://www.gnupg.org/related_software/gpgme/")
(synopsis "library providing simplified access to GnuPG functionality")
(description
--
1.8.4
next prev parent reply other threads:[~2014-02-20 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 10:31 [PATCH] gnu: Add libgpg-error as propagated inputs to gnupg, gpgme, and pinentry Mark H Weaver
2014-02-19 13:43 ` Ludovic Courtès
2014-02-20 3:24 ` Mark H Weaver [this message]
2014-02-20 14:18 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761oa8o17.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).