From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add mcrypt
Date: Sun, 25 May 2014 00:34:48 +0200
Message-ID: <8761ku956f.fsf@gnu.org>
References: <874n0fray8.fsf@member.fsf.org> <20140524085352.GA16714@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42490)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WoKWl-0000En-0x
	for Guix-devel@gnu.org; Sat, 24 May 2014 18:34:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WoKWg-0004xR-CV
	for Guix-devel@gnu.org; Sat, 24 May 2014 18:34:54 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:39325)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WoKWg-0004wW-62
	for Guix-devel@gnu.org; Sat, 24 May 2014 18:34:50 -0400
In-Reply-To: <20140524085352.GA16714@debian> (Andreas Enge's message of "Sat,
	24 May 2014 10:53:52 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: Guix-devel@gnu.org

Andreas Enge <andreas@enge.fr> skribis:

> On Sat, May 24, 2014 at 12:40:31AM -0500, Eric Bavier wrote:
>> +    (native-inputs `(("file" ,file)))
>> +    (arguments
>> +     `(#:phases (alist-cons-before
>> +                 'configure 'patch-configure
>> +                 (lambda _
>> +                   (substitute* "configure"
>> +                     (("/usr/bin/file")
>> +                      (which "file"))))
>> +                 %standard-phases)))
>
> Is this really needed? Lots of packages using the autotools look for "fil=
e",
> and when it is not available, nothing bad seems to happen. I was told bef=
ore
> to just not bother.

Agreed.

Nikita Karetnikov <nikita@karetnikov.org> skribis:

>> This patch adds Mcrypt, and two library dependencies.  Comments
>> welcome.
>
> I believe the libraries should be listed in the commit message as new
> variables.  Ludo, WDYT?

Agreed, in the subject line.

Ludo=E2=80=99.