From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@gmail.com>
Subject: Re: [PATCH 22/31] gnu: Add python-pycrypto.
Date: Fri, 05 Sep 2014 13:55:32 -0500
Message-ID: <8761h13niz.fsf@gmail.com>
References: <1409930317-13220-1-git-send-email-dthompson2@worcester.edu>
	<1409930317-13220-22-git-send-email-dthompson2@worcester.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50812)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1XPyfa-0001Hu-Eo
	for guix-devel@gnu.org; Fri, 05 Sep 2014 14:55:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1XPyfR-00064j-2M
	for guix-devel@gnu.org; Fri, 05 Sep 2014 14:55:38 -0400
Received: from mail-ie0-x233.google.com ([2607:f8b0:4001:c03::233]:45549)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@gmail.com>) id 1XPyfQ-00064A-NC
	for guix-devel@gnu.org; Fri, 05 Sep 2014 14:55:28 -0400
Received: by mail-ie0-f179.google.com with SMTP id tr6so14718458ieb.38
	for <guix-devel@gnu.org>; Fri, 05 Sep 2014 11:55:27 -0700 (PDT)
In-reply-to: <1409930317-13220-22-git-send-email-dthompson2@worcester.edu>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org


David Thompson writes:

> * gnu/packages/python.scm (python-pycrypto, python2-pycrypto): New variables.
> ---
>  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 2e16838..886dc03 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -1598,3 +1598,35 @@ somewhat intelligeble.")
>  (define-public python2-pyjwt
>    (package-with-python2 python-pyjwt))
>  
> +(define-public python-pycrypto

As I pointed out on IRC, this package is redundant with the one added in
cafc3f5a.

> +    (inputs
> +     `(("python" ,python) ;; need libpython3.3m
> +       ("python-setuptools" ,python-setuptools)
> +       ("gmp" ,gmp)))

Should python-setuptools perhaps go in native-inputs (this question
applies to the other patches sent in this batch as well)?  Not all of
the existing python packages follow this, but maybe they should.
Someone more practiced with cross-compilation might know better.

-- 
Eric Bavier