From mboxrd@z Thu Jan  1 00:00:00 1970
From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer?=)
Subject: Re: [PATCH] gnu: Add mesa-demos.
Date: Sat, 14 Mar 2015 16:04:25 +0100
Message-ID: <8761a37h8m.fsf@taylan.uni.cx>
References: <87egos7wfs.fsf@taylan.uni.cx> <87oanvy8je.fsf@gnu.org>
	<87a8zf7hj9.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <taylanbayirli@gmail.com>) id 1YWnc5-0007I1-8o
	for guix-devel@gnu.org; Sat, 14 Mar 2015 11:04:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <taylanbayirli@gmail.com>) id 1YWnc4-0003F5-6S
	for guix-devel@gnu.org; Sat, 14 Mar 2015 11:04:29 -0400
In-Reply-To: <87a8zf7hj9.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Sat, 14 Mar 2015 15:58:02 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes:

>>> +        ("libxshmfence" ,libxshmfence)
>>
>> Please add a margin comment explaining the reason.
>
> It's in the "Requires.private" field of the gl.pc pkg-config file.  The
> same seems to be the case for other packages in the propagated-inputs
> list.  Should it be explained for all of them?..

I just noticed that there's more packages in that .pc section which are
in the inputs but not propagated inputs.  Should I propagate them all?

Here is the whole .pc field, pretty-printed:

Requires.private:
libdrm >=3D 2.4.38
x11
xext
xdamage
xfixes
x11-xcb
xcb
xcb-glx >=3D 1.8.1
xcb-dri2 >=3D 1.8
xcb-dri3
xcb-present
xcb-sync
xshmfence >=3D 1.1
xxf86vm

And here are the propagated and normal inputs prior to my patch:

(propagated-inputs
  `(("glproto" ,glproto)
    ("libdrm" ,libdrm)
    ("libx11" ,libx11)
    ("libxdamage" ,libxdamage)
    ("libxxf86vm" ,libxxf86vm)))
(inputs
  `(("udev" ,eudev)
    ("dri2proto" ,dri2proto)
    ("dri3proto" ,dri3proto)
    ("libxshmfence" ,libxshmfence)
    ("presentproto" ,presentproto)
    ("expat" ,expat)
    ("libxfixes" ,libxfixes)
    ("libxml2" ,libxml2)
    ;; TODO: Add 'libva'
    ;; TODO: Add 'libxml2-python' for OpenGL ES 1.1 and 2.0 support
    ("makedepend" ,makedepend)
    ("s2tc" ,s2tc)))

So I think libxshmfence and libxfixes should be propagated, right?

Taylan