From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Replace ATLAS with OpenBLAS (+lapack)
Date: Mon, 15 Jun 2015 00:04:11 +0200
Message-ID: <87616q54mc.fsf@gnu.org>
References: <idjioat2rhn.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z4G0q-0001F5-UR
	for guix-devel@gnu.org; Sun, 14 Jun 2015 18:04:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z4G0l-0002bu-UX
	for guix-devel@gnu.org; Sun, 14 Jun 2015 18:04:20 -0400
In-Reply-To: <idjioat2rhn.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 12 Jun 2015 11:41:40 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> attached are three more patches to replace ATLAS with OpenBLAS in
> python.scm.

Good!

> From aeb4f541486d5bb02d4002380e8f7be49967b10d Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 12 Jun 2015 10:48:58 +0200
> Subject: [PATCH 1/3] gnu: python-numpy-bootstrap: Add lapack to inputs.
>
> * gnu/packages/python.scm (python-numpy-bootstrap)[inputs]: Add lapack to
>   inputs, because OpenBLAS does not include lapack functions.

OK.

> From a26127d8ecd9170d11350f7085c9e39aa4018b4a Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 12 Jun 2015 11:30:51 +0200
> Subject: [PATCH 2/3] gnu: python-scipy: Build with OpenBLAS and lapack.
>
> * gnu/packages/python.scm (python-scipy)[inputs]: Remove "atlas", add "la=
pack"
>   and "openblas".
> * gnu/packages/python.scm (python-scipy)[arguments]: Replace phase
>   "set-environment-variables" with "configure-openblas".

OK.

> From 79d29126037cd227b01b3a193bf016ec9e12b4fb Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 12 Jun 2015 11:34:39 +0200
> Subject: [PATCH 3/3] gnu: python-scikit-learn: Use OpenBLAS instead of AT=
LAS.
>
> * gnu/packages/python.scm (python-scikit-learn)[inputs]: Replace "atlas" =
with
>   "openblas".

Please mention how the phases are modified in the commit log.

Otherwise OK.

Thanks!

Ludo=E2=80=99.