From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] R build system and CRAN importer (updated)
Date: Sat, 29 Aug 2015 23:15:04 +0200
Message-ID: <87613xokyv.fsf@gnu.org>
References: <idjr3no8o9s.fsf@bimsb-sys02.mdc-berlin.net>
	<idjwpwyb6px.fsf@bimsb-sys02.mdc-berlin.net>
	<CAJ=RwfatZX7nGsS8T6dDsSzjrkX7gX7=rj-tDQxVDQ4ASz_Qag@mail.gmail.com>
	<idjr3msahnd.fsf@bimsb-sys02.mdc-berlin.net>
	<idjlhcy9grk.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZVnSy-0006WD-4E
	for guix-devel@gnu.org; Sat, 29 Aug 2015 17:15:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZVnSu-0006X3-Tu
	for guix-devel@gnu.org; Sat, 29 Aug 2015 17:15:12 -0400
In-Reply-To: <idjlhcy9grk.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Wed, 26 Aug 2015 18:05:51 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> From 1c726be7746021f5d967d12154c057391e24585d Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 24 Jul 2015 16:49:57 +0200
> Subject: [PATCH 1/2] import: Add 'cran' importer.
>
> * guix/import/cran.scm: New file.
> * guix/scripts/import.scm: Add "cran" to 'importers'.
> * guix/scripts/import/cran.scm: New file.
> * tests/cran.scm: New file.
> * Makefile.am (MODULES): Add 'guix/import/cran.scm' and
>   'guix/scripts/import/cran.scm'.
>   (SCM_TESTS): Add 'tests/cran.scm'.
> * doc/guix.texi (Invoking guix import): Document it.
> * po/guix/POTFILES.in: Add 'guix/scripts/import/cran.scm'.

Nice work.

> +(define string->license
> +  (match-lambda
> +   ("AGPL-3" 'agpl3)

Perhaps =E2=80=98agpl3+=E2=80=99 is a better match?

> +   ("GPL-2" 'gpl2)

=E2=80=98gpl2+=E2=80=99

> +   ("GPL-3" 'GPL3)

Lower-case, and probably with =E2=80=98+=E2=80=99 as well.

> +   ("LGPL-2" 'lgpl2.0)
> +   ("LGPL-2.1" 'lgpl2.1)
> +   ("LGPL-3" 'lgpl3)

=E2=80=98+=E2=80=99?

> +(define (format-inputs names)
> +  "Generate a sorted list of package inputs from a list of package NAMES=
."
> +  (sort
> +    (map (lambda (name)
> +           (list name (list 'unquote (string->symbol name))))
> +         names)
> +    (lambda args
> +      (match args
> +        (((a _ ...) (b _ ...))
> +         (string-ci<? a b))))))

Might be more readable like this:

  (map (lambda ...)
       (sort names string-ci<?))

Otherwise LGTM.  OK to push with these changes.

> From 8271e8a5e7d237693e8d4b7b34e4a484b9a1fc22 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Fri, 31 Jul 2015 14:47:34 +0200
> Subject: [PATCH 2/2] build: Add R build system.
>
> * guix/build-system/r.scm: New file.
> * guix/build/r-build-system: New file.
> * Makefile.am (MODULES): Add new files.
> * doc/guix.texi (Build Systems): Document r-build-system.

[...]

> +(define (call-r command params)

Nitpick: I=E2=80=99d call it =E2=80=98invoke-r=E2=80=99 (a function is call=
ed, a program is
invoked.)

Thanks!

Ludo=E2=80=99.