From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add ruby-rack.
Date: Mon, 07 Sep 2015 18:02:30 +0200
Message-ID: <87613mtdyh.fsf@gnu.org>
References: <87twr9ykn7.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45162)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZYysO-0006Dw-FQ
	for guix-devel@gnu.org; Mon, 07 Sep 2015 12:02:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZYysL-0007s6-RF
	for guix-devel@gnu.org; Mon, 07 Sep 2015 12:02:36 -0400
In-Reply-To: <87twr9ykn7.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Fri, 04 Sep 2015 16:50:04 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> From a740a5ca98c02bd0e9c792677dfc8ff8464c8365 Mon Sep 17 00:00:00 2001
> From: David Thompson <dthompson2@worcester.edu>
> Date: Fri, 4 Sep 2015 16:47:52 -0400
> Subject: [PATCH] gnu: Add ruby-rack.
>
> * gnu/packages/ruby.scm (ruby-rack): New variable.

[...]

> +         (add-before 'check 'fix-tests
> +           (lambda _
> +             ;; A few of the tests use the length of a file on disk for
> +             ;; Content-Length and Content-Range headers.  However, this=
 file
> +             ;; has a shebang in it which an earlier phase patches, grow=
ing
> +             ;; the file size from 193 to 239 bytes.
> +             (substitute* '("test/spec_file.rb")
> +               (("193") "239")

I think this phase should use the actual length of the shebang, in case
the store is not at /gnu/store, with something like:

  (- (string-length (which "ruby")) (string-length "/usr/bin/ruby"))

Could you look into it?

TIA,
Ludo=E2=80=99.