unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Lirzin <mthl@gnu.org>
To: guix-devel@gnu.org
Cc: Eric Bavier <bavier@member.fsf.org>
Subject: guix/scripts/refresh.scm:331:14: warning: non-literal format string.
Date: Mon, 09 Nov 2015 12:30:03 +0100	[thread overview]
Message-ID: <87611bv29w.fsf@gnu.org> (raw)

Hi,

I haved noticed a warning when building Guix (master) with Guile 2.0.11:

  guix/scripts/refresh.scm:331:14: warning: non-literal format string
  wrote `guix/scripts/refresh.go'

Here is the snippet of the code producing this warning:

--8<---------------cut here---------------start------------->8---
              (format (current-output-port)
                      (N_ (N_ "A single dependent package: ~2*~{~a~}~%"
                              "Building the following package would ensure ~d \
dependent packages are rebuilt; ~*~{~a~^ ~}~%"
                              total-dependents)
                          "Building the following ~d packages would ensure ~d \
dependent packages are rebuilt: ~{~a~^ ~}~%"
                          (length rebuilds))
                      (length rebuilds) total-dependents rebuilds)
--8<---------------cut here---------------end--------------->8---

I'm not sure how Gettext plural forms should be used so:

- If the code is correct, I think we should provide a comment announcing
  the warning and explaining why this is OK.

- else, how can we fix it?

TIA,

--
Mathieu Lirzin

             reply	other threads:[~2015-11-09 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 11:30 Mathieu Lirzin [this message]
2015-11-11 21:11 ` guix/scripts/refresh.scm:331:14: warning: non-literal format string Ludovic Courtès
2015-11-16 22:12   ` Mathieu Lirzin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87611bv29w.fsf@gnu.org \
    --to=mthl@gnu.org \
    --cc=bavier@member.fsf.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).