From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 5/5] gnu: Build lua-5.1 with dynamic library support and a
	dynamic library.
Date: Sun, 13 Dec 2015 17:27:36 +0100
Message-ID: <876102wbyf.fsf@gnu.org>
References: <cover.1446485963.git.leo@famulari.name>
	<cover.1446485963.git.leo@famulari.name>
	<fadbe5c0eb063ae24e6f36afdc08e58ec554628e.1446485963.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a89Ut-0002dP-Og
	for guix-devel@gnu.org; Sun, 13 Dec 2015 11:27:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a89Uo-0007xs-Pr
	for guix-devel@gnu.org; Sun, 13 Dec 2015 11:27:43 -0500
In-Reply-To: <fadbe5c0eb063ae24e6f36afdc08e58ec554628e.1446485963.git.leo@famulari.name>
	(Leo Famulari's message of "Mon, 2 Nov 2015 12:46:44 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/lua.scm (lua-5.1)[arguments]: Rewrite make-flags so that
>   Lua is built with platform-specific instructions for shared library
>   loading (dlopen).
> * gnu/packages/patches/lua51-liblua-so.patch: Install liblua.so with
>   execute bit set. Move "-fPIC" flag from patch to package definition.

[...]

> +       #:make-flags (list "PLAT=3D linux"
> +                          "CFLAGS=3D -O2 -Wall -fPIC $(MYCFLAGS)"
> +                          "MYLDFLAGS=3D -fPIC"

Why not just:

  MYCFLAGS=3D-fPIC

instead of CFLAGS=3D=E2=80=A6?  This would be consistent with how MYLDFLAGS=
 is
used.

> +                          (string-append "INSTALL_TOP=3D "
> +                                         (assoc-ref %outputs "out"))
> +                          (string-append "INSTALL_MAN=3D "
> +                                         (assoc-ref %outputs "out")
> +                                         "/share/man/man1"))))))

I=E2=80=99m under the impression that these two variables aren=E2=80=99t ne=
eded since
things already get installed in the right place, no?

Thanks,
Ludo=E2=80=99.