From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Vong <alexvong1995@gmail.com>
Subject: Re: [PATCH] gnu: youtube-dl: Add native-search-paths.
Date: Wed, 16 Dec 2015 19:49:46 +0800
Message-ID: <8760zy7gv9.fsf@gmail.com>
References: <874mfm76vp.fsf@gmail.com> <87r3iqwclg.fsf@gnu.org>
	<87a8pduspk.fsf@gmail.com> <87r3in7u8i.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52872)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alexvong1995@gmail.com>) id 1a9Aai-00052s-NP
	for guix-devel@gnu.org; Wed, 16 Dec 2015 06:49:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alexvong1995@gmail.com>) id 1a9Aad-0006jf-NA
	for guix-devel@gnu.org; Wed, 16 Dec 2015 06:49:56 -0500
In-Reply-To: <87r3in7u8i.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Tue, 15 Dec 2015 13:48:45 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Alex Vong <alexvong1995@gmail.com> skribis:
>
>> From 21db93d3caa4846882720a610a7fa0e0a2fe3162 Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Mon, 14 Dec 2015 20:00:52 +0800
>> Subject: [PATCH] gnu: youtube-dl: Install the man page and completion fi=
les.
>>
>> * gnu/packages/video.scm (youtube-dl) [arguments]: Add
>> fix-the-data-files-path phase.
>
> Applied, thanks.  While at it, I made few changes: added a copyright
> line for you, changed =E2=80=9Cpath=E2=80=9D to =E2=80=9Cdirectory=E2=80=
=9D (GNU has the convention that
> =E2=80=9Cpath=E2=80=9D means =E2=80=9Csearch path=E2=80=9D, not file/dire=
ctory), and rename the Bash
> completion file so that it is picked up.
>
Thanks too!

So the bash completion file has the wrong name, should we report it to
upstream? Is bash picky about the completion file name or is it just a
matter of style? I cannot test it since I am not using guixsd.

Currently, I need to put the following to my ".bashrc" to make bash
completion works:

if test "x$BASH" !=3D "x"
then
    for bash_completion_file in \
        $(find -L \
               "/usr/local/etc/bash_completion.d" \
               "$HOME/.guix-profile/etc/bash_completion.d" \
               "$HOME/.guix-profile/share/bash-completion/completions" \
               -type f)
    do
        . "$bash_completion_file"
    done
fi

But this makes bash slower to start. Should we put some instruction on
the manual?

> Let me know what you think.
>
> Thanks!
>
> Ludo=E2=80=99.

Cheers,
Alex