Re: [PATCH] gnu: youtube-dl: Add native-search-paths.

[Alex Vong <alexvong1995@gmail.com>]

ludo@gnu.org (Ludovic Courtès) writes:

> Alex Vong <alexvong1995@gmail.com> skribis:
>
>> From 21db93d3caa4846882720a610a7fa0e0a2fe3162 Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Mon, 14 Dec 2015 20:00:52 +0800
>> Subject: [PATCH] gnu: youtube-dl: Install the man page and completion files.
>>
>> * gnu/packages/video.scm (youtube-dl) [arguments]: Add
>> fix-the-data-files-path phase.
>
> Applied, thanks.  While at it, I made few changes: added a copyright
> line for you, changed “path” to “directory” (GNU has the convention that
> “path” means “search path”, not file/directory), and rename the Bash
> completion file so that it is picked up.
>
Thanks too!

So the bash completion file has the wrong name, should we report it to
upstream? Is bash picky about the completion file name or is it just a
matter of style? I cannot test it since I am not using guixsd.

Currently, I need to put the following to my ".bashrc" to make bash
completion works:

if test "x$BASH" != "x"
then
    for bash_completion_file in \
        $(find -L \
               "/usr/local/etc/bash_completion.d" \
               "$HOME/.guix-profile/etc/bash_completion.d" \
               "$HOME/.guix-profile/share/bash-completion/completions" \
               -type f)
    do
        . "$bash_completion_file"
    done
fi

But this makes bash slower to start. Should we put some instruction on
the manual?

> Let me know what you think.
>
> Thanks!
>
> Ludo’.

Cheers,
Alex