From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Vong Subject: Re: [PATCH] Replace broken LADSPA URL. Date: Tue, 29 Dec 2015 21:15:33 +0800 Message-ID: <8760zhmm4q.fsf@gmail.com> References: <87fv05oi2l.fsf@elephly.net> <87611110bq.fsf@gmail.com> <87ziydlzzb.fsf@elephly.net> <87bnas7gcd.fsf@gnu.org> <878u4g2bvf.fsf@gmail.com> <87lh8frqgj.fsf@gmail.com> <8737umo8uh.fsf@gnu.org> <87fuymim89.fsf@gmail.com> <87bn9ailxs.fsf@gmail.com> <87mvsu4bjt.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDu7p-0000UK-Rc for guix-devel@gnu.org; Tue, 29 Dec 2015 08:15:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDu7l-0007LY-TF for guix-devel@gnu.org; Tue, 29 Dec 2015 08:15:41 -0500 In-Reply-To: <87mvsu4bjt.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 28 Dec 2015 20:29:10 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: "guix-devel@gnu.org" , Alex Kost Ricardo Wurmus writes: > Alex Vong writes: > >> From 2feefc6fd7162d7226015aa296ace0c8e7d034bf Mon Sep 17 00:00:00 2001 >> From: Alex Vong >> Date: Thu, 12 Nov 2015 01:19:44 +0800 >> Subject: [PATCH] gnu: ladspa: Update urls. >> >> * gnu/packages/audio.scm (ladspa): Update source and home page url. >> >> Thanks to Ricardo Wurmus for suggesting downloading the source >> from Internet Archive. > > Thanks, but attribution is not required here :) > OK... >> gnu/packages/audio.scm | 29 +++++++++++++++++++---------- >> 1 file changed, 19 insertions(+), 10 deletions(-) >> >> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm >> index 6a8347a..9f3c217 100644 >> --- a/gnu/packages/audio.scm >> +++ b/gnu/packages/audio.scm >> @@ -817,15 +817,22 @@ plugin function as a JACK application.") >> (package >> (name "ladspa") >> (version "1.13") >> - (source (origin >> - (method url-fetch) >> - (uri (string-append >> - "http://www.ladspa.org/download/ladspa_sdk_" >> - version >> - ".tgz")) >> - (sha256 >> - (base32 >> - "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))= )) >> + (source >> + (origin >> + (method url-fetch) >> + ;; Since the official link is dead, >> + ;; we download the tarball from Debian or Internet Archive. >> + (uri (list (string-append "http://http.debian.net" >> + "/debian/pool/main/l/ladspa-sdk/ladspa= -sdk_" >> + version >> + ".orig.tar.gz") > > My preference is to keep =E2=80=9Cversion=E2=80=9D and the following stri= ng on the same > line because they are both short. > Is it a lisp / scheme convention to do this? I always think I should call a function like this: (func arg1 arg2 ...) or (func arg1 arg2 ...) >> + (string-append "https://web.archive.org/web/20140717172251/" >> + "http://www.ladspa.org/download/ladspa= _sdk_" >> + version >> + ".tgz"))) > > Same here. (It=E2=80=99s just a nitpick.) > >> + (sha256 >> + (base32 >> + "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm")))) >> (build-system gnu-build-system) >> (arguments >> `(#:tests? #f ; the "test" target is a listening test only >> @@ -843,7 +850,9 @@ plugin function as a JACK application.") >> (("^CC.*") "CC =3D gcc\n") >> (("^CPP.*") "CPP =3D g++\n")))) >> (alist-delete 'build %standard-phases)))) >> - (home-page "http://ladspa.org") >> + ;; Since the home page is gone, we provide a link to the archived v= ersion. >> + (home-page >> + "https://web.archive.org/web/20140729190945/http://www.ladspa.org/= ") >> (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)") >> (description >> "LADSPA is a standard that allows software audio processors and ef= fects > > Do you have permission to push or should I apply this on your behalf? > No, I don't have push right. I am more of a user-programmer right now :) > ~~ Ricardo