From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christopher Allan Webber <cwebber@dustycloud.org>
Subject: Re: [PATCH 2/2] gnu: Add python-pastescript.
Date: Thu, 25 Feb 2016 11:03:35 -0800
Message-ID: <8760xcfw9o.fsf@dustycloud.org>
References: <87a8mr8a9s.fsf@dustycloud.org> <20160225012340.GB31607@jasmine>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56513)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aZ1CM-0003Tu-OE
	for guix-devel@gnu.org; Thu, 25 Feb 2016 14:03:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aZ1CM-0000V7-32
	for guix-devel@gnu.org; Thu, 25 Feb 2016 14:03:38 -0500
Received: from dustycloud.org ([2600:3c02::f03c:91ff:feae:cb51]:60960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aZ1CL-0000U5-R3
	for guix-devel@gnu.org; Thu, 25 Feb 2016 14:03:37 -0500
In-reply-to: <20160225012340.GB31607@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org


Leo Famulari writes:

> On Tue, Feb 23, 2016 at 12:03:11PM -0800, Christopher Allan Webber wrote:
>> * gnu/packages/python.scm (python-pastescript, python2-pastescript):
>>   New variables.
>
> [...]
>
>> +     '(;; Unfortunately, this requires the latest unittest2,
>> +       ;; but that requires traceback2 which requires linecache2 which requires
>> +       ;; unittest2.  So we're skipping tests for now.
>> +       ;; (Note: Apparently linetest2 only needs unittest2 for its tests,
>> +       ;; so in theory we could get around this situation somehow.) 
>                                                                       ^
> Trailing white space -------------------------------------------------|

Oops!  Thanks.  (I should use whitespace-mode more often!)

>> +       #:tests? #f))
>> +    (synopsis
>> +     "Pluggable command line tool for serving web applications and more")
>> +    (description
>> +     "PasteScript is an extensible  command line tool which provides a variety
>> +of features, from launching web applications to bootstrapping project layouts.")
>
> The first half of this sentence applies to most command-line tools ;)
>
> Otherwise okay!

Fixed to be a bit more clear that "extensible" here refers to "plugins".

Thanks for the review.  Made those changes and pushed!