unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Allan Webber <cwebber@dustycloud.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] gnu: Add python-pastescript.
Date: Thu, 25 Feb 2016 11:03:35 -0800	[thread overview]
Message-ID: <8760xcfw9o.fsf@dustycloud.org> (raw)
In-Reply-To: <20160225012340.GB31607@jasmine>


Leo Famulari writes:

> On Tue, Feb 23, 2016 at 12:03:11PM -0800, Christopher Allan Webber wrote:
>> * gnu/packages/python.scm (python-pastescript, python2-pastescript):
>>   New variables.
>
> [...]
>
>> +     '(;; Unfortunately, this requires the latest unittest2,
>> +       ;; but that requires traceback2 which requires linecache2 which requires
>> +       ;; unittest2.  So we're skipping tests for now.
>> +       ;; (Note: Apparently linetest2 only needs unittest2 for its tests,
>> +       ;; so in theory we could get around this situation somehow.) 
>                                                                       ^
> Trailing white space -------------------------------------------------|

Oops!  Thanks.  (I should use whitespace-mode more often!)

>> +       #:tests? #f))
>> +    (synopsis
>> +     "Pluggable command line tool for serving web applications and more")
>> +    (description
>> +     "PasteScript is an extensible  command line tool which provides a variety
>> +of features, from launching web applications to bootstrapping project layouts.")
>
> The first half of this sentence applies to most command-line tools ;)
>
> Otherwise okay!

Fixed to be a bit more clear that "extensible" here refers to "plugins".

Thanks for the review.  Made those changes and pushed!

      reply	other threads:[~2016-02-25 19:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 20:03 [PATCH 2/2] gnu: Add python-pastescript Christopher Allan Webber
2016-02-25  1:23 ` Leo Famulari
2016-02-25 19:03   ` Christopher Allan Webber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760xcfw9o.fsf@dustycloud.org \
    --to=cwebber@dustycloud.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).