From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: xfce: Don’t wrap startxfce4.
Date: Wed, 02 Mar 2016 08:33:17 +0800 [thread overview]
Message-ID: <8760x590s2.fsf_-_@member.fsf.org> (raw)
In-Reply-To: <87lh61nb3e.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 01 Mar 2016 22:26:45 +0100")
ludo@gnu.org (Ludovic Courtès) writes:
> iyzsong@member.fsf.org (宋文武) skribis:
>
> [...]
>>
>> This package was introduced before the ‘etc/profile’ where enviroment
>> variables from search-paths are set. So, the wrapper is redundant now.
>
> The wrapper would still be useful when it’s not installed in a profile
> (for instance, when running $(guix build xfce4)/bin/startxfce4), but
> that’s probably not a use case worth supporting in this case.
> Thoughts?
I guess so, in that way other packages aren't in PATH.
>
>> From 6f6ba4e8c347770b279e9344ba49bf305cd41da8 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
>> Date: Mon, 29 Feb 2016 14:57:56 +0800
>> Subject: [PATCH] gnu: xfce: Don't wrap 'startxfce4'.
>>
>> The necessary environment variables are set by 'etc/profile' now.
>>
>> * gnu/packages/xfce.scm (xfce)[build-system]: Use 'trivial-build-system'.
>> [arguments]: Simplify.
>
> Otherwise the patch LGTM.
Pushed, thanks!
next prev parent reply other threads:[~2016-03-02 0:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 20:36 Xfce collision Andreas Enge
2016-02-29 8:46 ` [PATCH] gnu: xfce: Don’t wrap startxfce4. (Re: Xfce collision) 宋文武
2016-03-01 21:26 ` Ludovic Courtès
2016-03-02 0:33 ` 宋文武 [this message]
2016-02-29 8:47 ` 宋文武
2016-02-29 8:48 ` 宋文武
2016-02-29 8:49 ` 宋文武
2016-02-29 8:50 ` 宋文武
2016-02-29 8:50 ` 宋文武
2016-02-29 8:50 ` 宋文武
2016-02-29 9:26 ` 宋文武
2016-02-29 8:50 ` 宋文武
2016-02-29 8:50 ` 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760x590s2.fsf_-_@member.fsf.org \
--to=iyzsong@member.fsf.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).