From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] Emacs Smartparens Date: Mon, 16 May 2016 17:35:24 +0300 Message-ID: <8760ueqdeb.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2JcK-0008Pw-5T for guix-devel@gnu.org; Mon, 16 May 2016 10:35:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2JcE-0002LS-AP for guix-devel@gnu.org; Mon, 16 May 2016 10:35:31 -0400 Received: from mail-lf0-x232.google.com ([2a00:1450:4010:c07::232]:35514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2JcD-0002LH-VA for guix-devel@gnu.org; Mon, 16 May 2016 10:35:26 -0400 Received: by mail-lf0-x232.google.com with SMTP id j8so117236949lfd.2 for ; Mon, 16 May 2016 07:35:25 -0700 (PDT) In-Reply-To: (catonano@gmail.com's message of "Mon, 16 May 2016 15:32:04 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Catonano Cc: guix-devel@gnu.org Catonano (2016-05-16 16:32 +0300) wrote: > Ok this is my second attempt > > This time it's Smartparens Thanks! > I used the emacs build system this time and I payied a bit more > attention to the propagated inputs. I'm not sure about the native > input though There is no need to specify emacs in native-inputs if emacs-build-system is used. I have the same comments as for the zenburn patch (especially about the way you attach it; I can't really do anything when it is attached like this), so let's deal with that patch at first and then you can update this patch accordingly, if you don't mind. Sorry for the inconvenience :-) > From 2e15843c941fc470cfe20275c4343c300b9dc8de Mon Sep 17 00:00:00 > 2001 > From: humanitiesNerd > Date: Sun, 15 May 2016 20:40:14 +0200 > Subject: [PATCH] package definition for Smartparens appended to > =C2=A0gnu/packages/emacs.scm > > --- > =C2=A0gnu/packages/emacs.scm | 43 > +++++++++++++++++++++++++++++++++++++++++++ > =C2=A01 file changed, 43 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 11010b2..a311635 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -1559,3 +1559,46 @@ to recognize a name like \"RFC 1234\".=C2=A0 This > package enhances ffap so > =C2=A0that it correctly finds RFCs even when a space appears before the > =C2=A0number.") > =C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3+))) > + > + > + > +(define-public emacs-smartparens > +(package > +=C2=A0 (name "emacs-smartparens") > +=C2=A0 (version "1.7.1") > +=C2=A0 (source > +=C2=A0=C2=A0=C2=A0 (origin > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method url-fetch) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (uri (string-append > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= "http://stable.melpa.org/packages/smartparens-" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= version > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= ".tar")) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "04dvavsvmdf6fljv= 30csfkqkglvaw421irlq89v6zf93p0ak0vg6")))) > +=C2=A0 (build-system emacs-build-system) > +=C2=A0 (propagated-inputs `(("emacs-dash" ,emacs-dash))) ; what about > cl-lib 0.3 ? cl-lib is not needed as it is a part of Emacs now. On MELPA, it is specified as the package dependency because in the previous versions of Emacs (< 24) there were no cl-lib library, so if a user have an old emacs and installs a package that requires cl-lib, it should also be installed. > +=C2=A0 (native-inputs `(("emacs" ,emacs-no-x))) > +=C2=A0 (home-page "https://github.com/Fuco1/smartparens") > +=C2=A0 (synopsis > +=C2=A0=C2=A0=C2=A0 "Automatic insertion, wrapping and paredit-like navig= ation with > user defined pairs.") Synopsis shouldn't end with ".". Did you check your package with "guix lint"? It should report about such things. > +=C2=A0 (description > +=C2=A0=C2=A0=C2=A0 "Smartparens is minor mode for Emacs that deals with = parens > pairs > +and tries to be smart about it.=C2=A0 It started as a unification effort > +to combine functionality of several existing packages in a single, > +compatible and extensible way to deal with parentheses, delimiters, > +tags and the like.=C2=A0 Some of these packages include autopair, > +textmate, wrap-region, electric-pair-mode, paredit and others.=C2=A0 With > +the basic features found in other packages it also brings many > +improvements as well as completely new features I don't think we need the text below in the description. > +For a basic overview, see github readme at > +https://github.com/Fuco1/smartparens > + > +For the complete documentation visit the documentation wiki located > +at https://github.com/Fuco1/smartparens/wiki > + > +If you like this project, you can donate here: > +https://www.paypal.com/cgi-bin/webscr?cmd=3D_s-xclick&hosted_button_id > =3DCEYP5YVHDRX8C > +") > +=C2=A0 (license license:gpl3+))) > > --=20 Alex