From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Jordan Subject: Re: [Patch] ruby-byebug@9.0.5 Date: Sun, 05 Jun 2016 17:22:02 -0400 Message-ID: <8760tngwlh.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> References: <87shwyxmnv.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> <57500842.5070000@uq.edu.au> <5750246F.5080006@uq.edu.au> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9fWA-0007Iw-45 for guix-devel@gnu.org; Sun, 05 Jun 2016 17:23:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9fW4-0004Oi-3y for guix-devel@gnu.org; Sun, 05 Jun 2016 17:23:33 -0400 Received: from forward4o.cmail.yandex.net ([37.9.109.248]:48931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9fW2-0004NS-K6 for guix-devel@gnu.org; Sun, 05 Jun 2016 17:23:28 -0400 In-reply-to: <5750246F.5080006@uq.edu.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel Good Day Ben Woodcroft, This is what I have so far, although I'm not that familiar with byebug though. I'll try to dig a bit deeper to get a better understanding of what's going on. > It seems I was off-base a bit here. There was already a ruby-byebug > packaged, but it was somewhat out of date. Shall we simply update the > existing package instead of creating a new package? Wouldn't it be more useful to have one or versions of a package, since guix is capable of handling multiple versions? Though I have no problems upgrading the previous version, hopefully nothing will break. > I had a go at re-enabling tests which were disabled in the original > package - see the attached patch. Unfortunately it is still failing a > few tests. Would you like to take a look into why this might be? Here a summary of test info. The test "Byebug::SaveTest#test_save_shows_a_success_message" seems to fail cause it's looking for a file in a home directory that doesn't exist. Setting the HOME variable seems to solve that. As for the other failing tests, they seem to expect to finish in the temporary guix build directory. $ grep 'Failure:' $BUILD_LOG 1) Failure: 2) Failure: 5) Failure: 9) Failure: 10) Failure: 1) Failure: Byebug::FinishAfterReturnTest#test_finish_does_not_stop_in_byebug_internal_frames [/tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug-9.0.5/test/commands/finish_test.rb:88]: Expected program to have finished. Expected [["/tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug-9.0.5/test/support/utils.rb:61:in `debug_code'", #, @example_folder="/tmp/guix-build-ruby-byebug-9.0.5.drv-0", @failures=[]>, Byebug::TestUtils, ... 2) Failure: Byebug::BasicNextTest#test_next_does_not_stop_at_byebug_internal_frames [/tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug-9.0.5/test/commands/next_test.rb:57]: Expected program to have finished. Expected [["/tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug-9.0.5/test/support/utils.rb:61:in `debug_code'", #, @example_folder="/tmp/guix-build-ruby-byebug-9.0.5.drv-0", @failures=[]>, ... 5) Failure: Byebug::SaveTest#test_save_shows_a_success_message [/tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug-9.0.5/test/support/matchers.rb:27]: Expected ["", "[1, 5] in /tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160605-93-lrr6ae.rb", "1: module Byebug", "2: byebug", "=> 3: a = 2", "4: a + 3", "5: end", "(byebug)", "(byebug)"] to include ["Saved to '/homeless-shelter/.byebug_save'"] in order. ... 9) Failure: Byebug::FrameTest#test_frame_minus_one_sets_frame_to_the_last_one [/tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug-9.0.5/test/commands/frame_test.rb:78]: Expected location to be /tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160605-93-1w3cvx7.rb:1, but was /gnu/store/j86y28xf4q42bwlz98vhfjipf4rfb5bn-ruby-2.3.1/bin/rake:23 10) Failure: Byebug::WhereWithNotDeeplyNestedPathsTest#test_where_displays_current_backtrace_w_shorpaths_if_fullpath_disabled [/tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug-9.0.5/test/support/matchers.rb:27]: Expected ["", "[11, 20] in /tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160605-93-ojlsg9.rb", "11: to_int(str + 'x') + 5", "12: end", "13:", "14: def to_int(str)", "15: byebug", "=> 16: str.ord", "17: end", "18: end", "19:", "20: frame = ByebugTest2016060593Ojlsg9Class.new('f')", "(byebug)", "fullpath is off", "(byebug)", "--> #0 Byebug::ByebugTest2016060593Ojlsg9Class.to_int(str#String) at .../tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160605-93-ojlsg9.rb:16", "#1 Byebug::ByebugTest2016060593Ojlsg9Class.encode(str#String) at .../tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160605-93-ojlsg9.rb:11", "#2 Byebug::ByebugTest2016060593Ojlsg9Class.initialize(l#String) at .../tmp/guix-build-ruby-byebug-9.0.5.drv-0/byebug_test20160605-93-ojlsg9.rb:7", ... Respectfully, -- Matthew Jordan Sent with my mu4e