From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure flags.
Date: Tue, 07 Jun 2016 15:43:11 +0200 [thread overview]
Message-ID: <8760tl9ksw.fsf@gnu.org> (raw)
In-Reply-To: <e33375f5-0440-19c5-c4cd-da401e4c94b3@gmail.com> (Manolis Ragkousis's message of "Tue, 7 Jun 2016 15:00:44 +0300")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> From 984de2d0e26b1ddd860d0468453ee8679ced756d Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Tue, 7 Jun 2016 14:45:55 +0300
> Subject: [PATCH] gnu: hurd: Remove inputs no longer needed and move configure
> flags.
>
> * gnu/packages/hurd.scm (hurd-minimal)[arguments]: Move configure-flags from here..
> (hurd-headers)[arguments]: ..to here.
They are not just moved, there’s also the change for --host. It would
be great if, for clarity, you made one patch for the --host change (like
you did before), one for the actual move, and…
> (hurd-headers, hurd-minimal)[native-inputs]: Remove "autoconf".
… another one for this.
Does that sound reasonable?
Apart from this nitpicking, it looks good to me, thanks!
Ludo’.
prev parent reply other threads:[~2016-06-07 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 12:00 [PATCH] gnu: hurd: Remove inputs no longer needed and move configure flags Manolis Ragkousis
2016-06-07 12:19 ` Efraim Flashner
2016-06-07 12:42 ` Manolis Ragkousis
2016-06-07 13:43 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760tl9ksw.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).