From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/4] lint: Add 'inputs-should-be-sorted' check.
Date: Thu, 21 Jul 2016 18:00:24 +0200
Message-ID: <8760rzm15z.fsf@gnu.org>
References: <20160719164916.6597-1-david@craven.ch>
	<20160719164916.6597-4-david@craven.ch>
	<20160721081710.41c69c50@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37272)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQGOm-0007Ku-WD
	for guix-devel@gnu.org; Thu, 21 Jul 2016 12:00:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bQGOi-0001Cx-0T
	for guix-devel@gnu.org; Thu, 21 Jul 2016 12:00:31 -0400
In-Reply-To: <20160721081710.41c69c50@openmailbox.org> (Eric Bavier's message
	of "Thu, 21 Jul 2016 08:17:10 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org, David Craven <david@craven.ch>

Eric Bavier <ericbavier@openmailbox.org> skribis:

> On Tue, 19 Jul 2016 18:49:15 +0200
> David Craven <david@craven.ch> wrote:
>
>> * guix/scripts/lint.scm (check-inputs-should-be-sorted): Add it.
>> (lint-checker): Add it.
>> ---
>>  guix/scripts/lint.scm | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>>=20
>> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
>> index d64a066..d3a82c9 100644
>> --- a/guix/scripts/lint.scm
>> +++ b/guix/scripts/lint.scm
>> @@ -220,6 +220,21 @@ by two spaces; possible infraction~p at ~{~a~^, ~}")
>>                (when (string-suffix? ":bin" package-name) (warn package-=
name)))
>>                  labels)))))))
>>=20=20
>> +(define (check-inputs-should-be-sorted package)
>> +  ;; Emit a warning if inputs, native-inputs or propagated-inputs are n=
ot sorted.
>
> I don't think this needs to be a thing.  While I personally added the
> code in the cpan importer to sort inputs by name, I recognize that
> there are also valid reasons to not do that in some packages.  E.g.
> grouping a set of inputs that are all related to or required for some
> aspect of a package's functionality, etc.

Yeah, I agree.

Ludo=E2=80=99.