Re: [PATCH 3/4] lint: Add 'inputs-should-be-sorted' check.

[ludo@gnu.org (Ludovic Courtès)]

Eric Bavier <ericbavier@openmailbox.org> skribis:

> On Tue, 19 Jul 2016 18:49:15 +0200
> David Craven <david@craven.ch> wrote:
>
>> * guix/scripts/lint.scm (check-inputs-should-be-sorted): Add it.
>> (lint-checker): Add it.
>> ---
>>  guix/scripts/lint.scm | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>> 
>> diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
>> index d64a066..d3a82c9 100644
>> --- a/guix/scripts/lint.scm
>> +++ b/guix/scripts/lint.scm
>> @@ -220,6 +220,21 @@ by two spaces; possible infraction~p at ~{~a~^, ~}")
>>                (when (string-suffix? ":bin" package-name) (warn package-name)))
>>                  labels)))))))
>>  
>> +(define (check-inputs-should-be-sorted package)
>> +  ;; Emit a warning if inputs, native-inputs or propagated-inputs are not sorted.
>
> I don't think this needs to be a thing.  While I personally added the
> code in the cpan importer to sort inputs by name, I recognize that
> there are also valid reasons to not do that in some packages.  E.g.
> grouping a set of inputs that are all related to or required for some
> aspect of a package's functionality, etc.

Yeah, I agree.

Ludo’.