unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Roel Janssen <roel@gnu.org>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-pygame.
Date: Sat, 30 Jul 2016 15:52:06 +0200	[thread overview]
Message-ID: <8760rngrnd.fsf@gnu.org> (raw)
In-Reply-To: <8760rorv57.fsf@openmailbox.org>


Kei Kebreau writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> The python-pygame patch as promised. Note that it requires the
>> application of the most recently submitted libsmpeg patch. Would anyone
>> else like to test this? :-)

I've succesfully built both the libsmpeg patch and python-pygame.

> Please disregard the earlier patch. I had to add the other licenses and
> a description to the definition. Thanks to Roel for sharing a pygame definition!

Thank you for getting it to work!  I only have one comment:

>+               (system* "ln" "--symbolic" "Setup.in" "Setup")))))))
>+         ;; The default tries to install libraries into the python directory.
>+         ;; Using --install-lib, we can provide the correct path.
>+    (native-inputs
>+     `(("python-setuptools" ,python-setuptools)))

The comment seems to be out of place.  I don't even know where it
belongs to anymore.  Was this for another build phase customization? (it
seems to because of the indentation..).

Thank you.

Kind regards,
Roel Janssen

  reply	other threads:[~2016-07-30 13:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-29 21:13 [PATCH] gnu: Add python-pygame Kei Kebreau
2016-07-29 21:28 ` Kei Kebreau
2016-07-30 13:52   ` Roel Janssen [this message]
2016-07-30 14:26     ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760rngrnd.fsf@gnu.org \
    --to=roel@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).