From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: encfs: Update to 1.9.
Date: Mon, 12 Sep 2016 15:42:43 +0200
Message-ID: <8760q1tess.fsf@gnu.org>
References: <1473556426-19703-1-git-send-email-me@tobias.gr>
	<1473556426-19703-2-git-send-email-me@tobias.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42637)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjRVb-0000B5-E9
	for guix-devel@gnu.org; Mon, 12 Sep 2016 09:42:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bjRVW-0008CH-G7
	for guix-devel@gnu.org; Mon, 12 Sep 2016 09:42:50 -0400
In-Reply-To: <1473556426-19703-2-git-send-email-me@tobias.gr> (Tobias
	Geerinckx-Rice's message of "Sun, 11 Sep 2016 03:13:46 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * gnu/packages/crypto.scm (encfs): Update to 1.9.
> [source]: Remove bundled TinyXML2 in a snippet.
> [build-system]: Switch to cmake-build-system.
> [arguments]: Remove autotools-related phases and configure-flags.
> Don't use bundled TinyXML2.
> [native-inputs]: Remove autoconf, automake, libtool, and pkg-config.
> Add expect.
> [inputs]: Remove boost and rlog, while adding attr and tinyxml2.
> [license]: Add expat licence for new easylogging++.h file.

[...]

> +       (snippet '(for-each delete-file-recursively
> +                           (find-files "internal" "tinyxml2")))))

Note that the 2nd argument to =E2=80=98find-files=E2=80=99 is a regexp.  Is=
 this really
intended?

Otherwise LGTM, thanks!

Ludo=E2=80=99.