From mboxrd@z Thu Jan  1 00:00:00 1970
From: ng0 <ng0@we.make.ritual.n0.is>
Subject: Re: [PATCH] small patchseries to add the irc bot limnoria.
Date: Wed, 21 Sep 2016 08:33:01 +0000
Message-ID: <8760ppfy9u.fsf@we.make.ritual.n0.is>
References: <871t0hjnw7.fsf@we.make.ritual.n0.is>
	<20160920213826.GA6526@jasmine>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53511)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ng0@we.make.ritual.n0.is>) id 1bmcyD-0007dR-S0
	for guix-devel@gnu.org; Wed, 21 Sep 2016 04:33:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ng0@we.make.ritual.n0.is>) id 1bmcy9-0000eD-LK
	for guix-devel@gnu.org; Wed, 21 Sep 2016 04:33:32 -0400
Received: from aibo.runbox.com ([91.220.196.211]:56809)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ng0@we.make.ritual.n0.is>) id 1bmcy9-0000dh-En
	for guix-devel@gnu.org; Wed, 21 Sep 2016 04:33:29 -0400
In-Reply-To: <20160920213826.GA6526@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> writes:

> [ Unknown signature status ]
> On Sun, Sep 18, 2016 at 02:14:32PM +0000, ng0 wrote:
>> This is a small patchseries to add the bot limnoria, based on supybot.
>
> Thanks!
>
>> * gnu/packages/python.scm (python-socksipy-branch): New variable.
>
>> +    (home-page "http://code.google.com/p/socksipy-branch/")

Right, it is now https://code.google.com/archive/p/socksipy-branch/
until Google will finally to decide to shut down yet another product
people relied on.

>
> Error 404.
>
>> +(define-public python2-socksipy-branch
>> +  (package-with-python2
>> +   (strip-python2-variant python-socksipy-branch)))
>
> I don't think this needs strip-python2-variant. It should be enough to
> use package-with-python2.

I found this failed very often for me. I can try it again.

>> Subject: [PATCH 2/4] license: Add freebsd-doc.
>> 
>> * guix/licenses.scm (freebsd-doc): New variable.
>
> LGTM
>
>> Subject: [PATCH 3/4] gnu: Add python-feedparser.
>> 
>> * gnu/packages/python.scm (python-feedparser): New variable.
>
> LGTM
>
>> Subject: [PATCH 4/4] gnu: Add limnoria.
>> 
>> * gnu/packages/irc.scm (limnoria): New variable.
>
> LGTM. It would be nice to figure out how to run the tests, if they are
> meant to be run by distributions..
-- 
              ng0