Re: Display diffs between generations.

[Roel Janssen <roel@gnu.org>]

Roel Janssen writes:

> Ludovic Courtès writes:
>
>> Hi Roel!
>>
>> I realized we have not applied this --list-generations patch of yours,
>> which is a pity.  So…
>>
>> Roel Janssen <roel@gnu.org> skribis:
>>
>>> Vincent Legoll writes:
>>>
>>>> On Thu, Sep 1, 2016 at 2:12 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>>>>>>>>>   --list-generations=full
>>>>>>
>>>>>> I think keeping a way to see all generations in one go would be cool
>>>>>
>>>>> --list-generations would still display all the generations.  Or did you
>>>>> mean “a way to see *the content* of each generation”?
>>>>
>>>> I'm not sure to understand what you mean by "the content", what I meant
>>>> was to keep what current guix package -l shows us, i.e. do not alter current
>>>> UI, only add new things, but do not break existing practices when not mandated.
>>>
>>> What about adding a `--no-diff-format' or a `--diff-format' argument to
>>> `--list-generations'?
>>>
>>> We could then make two choices:  Default to the proposed diff format, or
>>> default to the full format (what we have now).  Depending on what we
>>> choose as default, we can implement the appropriate negating argument.
>>>
>>> I would prefer defaulting to the diff format..
>>
>> In the discussion that ensued, it seems there was a consensus to provide
>> only the diff format:
>>
>>   https://lists.gnu.org/archive/html/guix-devel/2016-09/msg00385.html
>>
>> So it seems all the lights are green.  :-)  Let me know if there’s
>> anything we should do to help!
>
> Thanks for the reminder.  I seem to have a lot to finish up :-).  I will
> work out the arguments and post a new version of the patch for final review.

My GNU mail hasn't been working for a couple of days, but now that it
does, I wonder if the initial patch I sent is fine as-is, since we agree
upon only showing the diff format.

Should I implement the --no-diff-format option to change to the
old behavior?

Kind regards,
Roel Janssen