From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodoros Foradis Subject: Re: [PATCH v4 1/1] gnu: Add plantuml. Date: Thu, 03 Nov 2016 16:29:26 +0200 Message-ID: <8760o4zlfd.fsf@openmailbox.org> References: <87pomiakvk.fsf@elephly.net> <20161102110341.28576-1-theodoros.for@openmailbox.org> <8737jac7af.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2J5E-0001ad-5d for guix-devel@gnu.org; Thu, 03 Nov 2016 10:33:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2J5B-0004Zz-0d for guix-devel@gnu.org; Thu, 03 Nov 2016 10:33:36 -0400 Received: from smtp9.openmailbox.org ([62.4.1.43]:52856) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2J5A-0004ZN-PF for guix-devel@gnu.org; Thu, 03 Nov 2016 10:33:32 -0400 In-reply-to: <8737jac7af.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Guix-devel Roel Janssen writes: > I tried running plantuml with the following snippet: > @startuml > A <..> B > @enduml > > And it crashes because it attempts to run "/usr/bin/dot". > > With the following snippet, we replace this "/usr/bin/dot" dependency > with the proper one from the graphviz input: > > (add-before 'build 'patch-usr-bin-dot > (lambda* (#:key inputs #:allow-other-keys) > (let ((dot (string-append (assoc-ref inputs "graphviz") > "/bin/dot"))) > (substitute* > "src/net/sourceforge/plantuml/cucadiagram/dot/GraphvizLinux.java" > (("/usr/bin/dot") dot))))) > Nice catch! Thanks for testing that. > Could you add this snippet? > > Other than this, it works fine for me. > > Kind regards, > Roel Janssen Let me know if I need to post an updated patch. -- Theodoros Foradis