Re: [PATCH 1/6] gnu: Add python-pycodestyle.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/python.scm (python-pycodestyle, python2-pycodestyle):
>   New variables.
> ---
>  gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 518ab3a..cb314e2 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3829,6 +3829,33 @@ simple and Pythonic domain language.")
>  (define-public python2-sqlalchemy
>    (package-with-python2 python-sqlalchemy))
>  
> +(define-public python-pycodestyle
> +  (package
> +    (name "python-pycodestyle")
> +    (version "2.0.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pycodestyle" version))
> +        (sha256
> +          (base32
> +            "1rz2v8506mdjdyxcnv9ygiw6v0d4dqx8z5sjyjm0w2v32h5l5w1p"))))
> +    (build-system python-build-system)
> +    (home-page "https://pycodestyle.readthedocs.io/")
> +    (synopsis "Python style guide checker")
> +    (description "pycodestyle (formerly pep8) is a tool to check your Python code against
                     ^^^
                     Either capitalize or wrap it in @code{} here.
> +some of the style conventions in @url{http://www.python.org/dev/peps/pep-0008/ PEP 8}.")

I think the @url syntax takes a comma rather than a space.

Otherwise LGTM.

> +    (license license:expat)
> +    (properties `((python2-variant . ,(delay python2-pycodestyle))))))
> +
> +(define-public python2-pycodestyle
> +  (let ((base (package-with-python2 (strip-python2-variant
> +                                     python-pycodestyle))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-setuptools" ,python2-setuptools)
> +         ,@(package-native-inputs base))))))
> +
>  (define-public python-sqlalchemy-utils
>    (package
>      (name "python-sqlalchemy-utils")

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]