From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <bavier@cray.com>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: Disable gnulib's test-lock test in packages?
Date: Sun, 29 Oct 2017 16:39:57 +0100 [thread overview]
Message-ID: <8760ay2caa.fsf@gnu.org> (raw)
In-Reply-To: <CY4PR11MB1718D5FB99FD403E073A19CAB75A0@CY4PR11MB1718.namprd11.prod.outlook.com> (Eric Bavier's message of "Fri, 27 Oct 2017 21:16:45 +0000")
Hi Eric,
Eric Bavier <bavier@cray.com> skribis:
> Several packages (libunistring, gettext, and libidn) in the guix bootstrap path hang on the "test-lock" test from gnulib while building on a aarch64 system I have access to. Some of them already have a patch applied that is supposed to fix the hang on system's with large core-counts, but it seems ineffective on my system. The findutils package is also affected, and there may be others, but I haven't discovered them yet.
>
> This commit in gnulib fixes the test-lock issue on my system, but doesn't help until our packages update their gnulib source:
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=be95b17ae933323cb757471f3d7c3f0617f9257e
>
> Not knowing any better, I created a dummy project to run the latest gnulib lock tests, attached for clarity.
So are you confident that the above commit fixes the issue?
As you might have seen, we already have
findutils-gnulib-multi-core.patch, gettext-gnulib-multi-core.patch, and
libunistring-gnulib-multi-core.patch, which turned out to be
insufficient to fix the problem.
> Until the updated lock module and tests make its way into these packages, I would like to ask if disabling these tests outright would be acceptable, similar to the attached patch. Thoughts?
Your patch looks like the safest approach; you can also remove
*gnulib-multi-core.patch while you’re at it. Then I think it’s OK for
‘core-updates’.
Thank you!
Ludo’.
next prev parent reply other threads:[~2017-10-29 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 21:16 Disable gnulib's test-lock test in packages? Eric Bavier
2017-10-29 15:39 ` Ludovic Courtès [this message]
2017-11-01 18:56 ` Eric Bavier
2017-11-05 16:12 ` Ludovic Courtès
2017-11-07 4:45 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760ay2caa.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bavier@cray.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).