unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder.
       [not found] ` <20181118094018.8076B209C1@vcs0.savannah.gnu.org>
@ 2018-11-20 17:46   ` Ludovic Courtès
  2018-11-20 18:49     ` Pierre Neidhardt
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-11-20 17:46 UTC (permalink / raw)
  To: guix-devel, Pierre Neidhardt

Hi Pierre,

mail@ambrevar.xyz (Pierre Neidhardt) skribis:

> commit d22ba64276c0bbacb77d0670635f67f053a16c6b
> Author: Pierre Neidhardt <mail@ambrevar.xyz>
> Date:   Sun Nov 18 10:38:54 2018 +0100
>
>     gnu: ccl: Include x86-headers and remove missing "contrib" folder.
>     
>     * gnu/packages/lisp.scm (ccl): Include x86-headers and remove missing "contrib" folder.

[...]

> +               (let ((dirs '("lib" "library" "examples" "tools" "objc-bridge"
> +                             ,(match (%current-system)
> +                                ("x86_64-linux"
> +                                 "x86-headers64")
> +                                ("i686-linux"
> +                                 "x86-headers")))))

This lacks a clause for the other supported systems.  This broke
evaluations of master on hydra & co., so I reverted this commit.  Of
course you’re welcome to reinstate provided it passes on all platforms!

‘guix lint’ will now check that the package can be lowered to a
derivation for all the systems it claims to support (commit
3b32891b12ee18c57b0fc346ed7dce8b6976066b).  So now it should be easier
to catch such issues.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder.
  2018-11-20 17:46   ` 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder Ludovic Courtès
@ 2018-11-20 18:49     ` Pierre Neidhardt
  2018-11-22  9:18       ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Pierre Neidhardt @ 2018-11-20 18:49 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

Oops!  Sorry for that.

What would be the most lispy way to return nothing from the match?
I'm thinking of splicing the resulting lists, but that sounds a bit overkill:

--8<---------------cut here---------------start------------->8---
(let ((dirs '("lib" "library" "examples" "tools" "objc-bridge"
              ,@(match (%current-system)
                 ("x86_64-linux"
                  '("x86-headers64"))
                 ("i686-linux"
                  '("x86-headers"))
                 (_ '())))))
--8<---------------cut here---------------end--------------->8---

Thoughts?

By the way the lint works, it's a nice addition! :D

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder.
  2018-11-20 18:49     ` Pierre Neidhardt
@ 2018-11-22  9:18       ` Ludovic Courtès
  2018-11-22 10:44         ` Pierre Neidhardt
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-11-22  9:18 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: guix-devel

Hello,

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Oops!  Sorry for that.

No problem.  :-)

> What would be the most lispy way to return nothing from the match?
> I'm thinking of splicing the resulting lists, but that sounds a bit overkill:
>
> (let ((dirs '("lib" "library" "examples" "tools" "objc-bridge"
>               ,@(match (%current-system)
>                  ("x86_64-linux"
>                   '("x86-headers64"))
>                  ("i686-linux"
>                   '("x86-headers"))
>                  (_ '())))))
>
> Thoughts?

LGTM.  Make sure ‘guix build’ and ‘guix lint’ are happy too.  :-)

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder.
  2018-11-22  9:18       ` Ludovic Courtès
@ 2018-11-22 10:44         ` Pierre Neidhardt
  0 siblings, 0 replies; 4+ messages in thread
From: Pierre Neidhardt @ 2018-11-22 10:44 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 78 bytes --]

Guix lint is happy.  Pushed!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-22 10:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20181118094017.18607.82174@vcs0.savannah.gnu.org>
     [not found] ` <20181118094018.8076B209C1@vcs0.savannah.gnu.org>
2018-11-20 17:46   ` 01/01: gnu: ccl: Include x86-headers and remove missing "contrib" folder Ludovic Courtès
2018-11-20 18:49     ` Pierre Neidhardt
2018-11-22  9:18       ` Ludovic Courtès
2018-11-22 10:44         ` Pierre Neidhardt

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).