From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Sample Subject: Re: core-updates freeze Date: Tue, 16 Jul 2019 23:24:42 -0400 Message-ID: <875zo1cphh.fsf@ngyro.com> References: <87blybrqjn.fsf@devup.no> <87ftncvbgs.fsf@gnu.org> <877e8oo08n.fsf@posteo.net> <874l3rmg8j.fsf@devup.no> <87ftna9gkg.fsf@posteo.net> <87o91udpty.fsf@ngyro.com> <87r26q542j.fsf@devup.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:38732) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnaYl-0000nC-Iw for guix-devel@gnu.org; Tue, 16 Jul 2019 23:24:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnaYk-00025n-7E for guix-devel@gnu.org; Tue, 16 Jul 2019 23:24:51 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57769) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnaYj-000259-U7 for guix-devel@gnu.org; Tue, 16 Jul 2019 23:24:50 -0400 In-Reply-To: <87r26q542j.fsf@devup.no> (Marius Bakke's message of "Tue, 16 Jul 2019 18:36:52 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Hi Marius, Marius Bakke writes: > Timothy Sample writes: > >> From ad931895edae97e2d6d77542fcbe8dc793f193f0 Mon Sep 17 00:00:00 2001 >> From: Timothy Sample >> Date: Tue, 16 Jul 2019 10:04:58 -0400 >> Subject: [PATCH] system: Write the timezone to /etc/timezone. >> >> * gnu/system.scm (operating-system-etc-service): Write the operating >> system timezone to /etc/timezone. >> >> Fixes . >> --- >> gnu/system.scm | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gnu/system.scm b/gnu/system.scm >> index 01be1243fe..75ac0632bb 100644 >> --- a/gnu/system.scm >> +++ b/gnu/system.scm >> @@ -716,6 +716,7 @@ fi\n"))) >> ;; to certain networks. Some discussion at >> ;; https://lists.gnu.org/archive/html/help-guix/2017-09/msg00037= .html >> ("hostname" ,(plain-file "hostname" (operating-system-host-name = os))) >> + ("timezone" ,(plain-file "timezone" (operating-system-timezone o= s))) >> ("localtime" ,(file-append tzdata "/share/zoneinfo/" >> (operating-system-timezone os))) >> ("sudoers" ,(operating-system-sudoers-file os)))))) >> --=20 >> 2.22.0 >> >> >> Thoughts? > > Looks good to me. Perhaps leave a comment that Glib uses this file to > figure out the current timezone? Pushed with a comment about GLib that references this discussion. > Though I notice Debian 10 creates /etc/timezone too, so maybe we just > missed a FHS update somewhere. I looked at FHS 3.0, which is the latest one I could find, and it didn=E2= =80=99t say anything. Searching around, the file has been around for a long time. It used to be mentioned in the systemd documentation, but now the docs talk about /etc/localtime being a symlink instead [1]. According to a Qt comment [2], Debian used to do what we are doing now until Jessie, then it made /etc/localtime a symlink (I presume they kept /etc/timezone for compatibility). All in all, it looks like a lot of other projects are moving away from /etc/timezone, so maybe we bet on the wrong horse, so to speak. It looks like Flatpack has started using it recently, though [3]. Either way, it should be easy enough to adapt if projects drop support for /etc/timezone. [1] https://github.com/systemd/systemd/commit/608da9e9b56be83ac394ea7a19cbd= acab94f6642 [2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=3D110e49c9cecca34dfaca= d33d19e04612cc2671b2 [3] https://github.com/flatpak/flatpak/issues/2190 -- Tim