From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 04/07: gnu: strace: Update to 5.2. Date: Tue, 06 Aug 2019 02:24:28 -0400 Message-ID: <875znaoloo.fsf@netris.org> References: <20190804160223.1357.19402@vcs0.savannah.gnu.org> <20190804160224.A29E4209DE@vcs0.savannah.gnu.org> <878ss7a7zb.fsf@netris.org> <871rxz341g.fsf@devup.no> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:59768) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1husto-00056J-AQ for guix-devel@gnu.org; Tue, 06 Aug 2019 02:24:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hustn-0005DH-8Q for guix-devel@gnu.org; Tue, 06 Aug 2019 02:24:44 -0400 Received: from world.peace.net ([64.112.178.59]:60988) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hustn-0005Cr-5R for guix-devel@gnu.org; Tue, 06 Aug 2019 02:24:43 -0400 In-Reply-To: <871rxz341g.fsf@devup.no> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Hi Marius, Marius Bakke wrote: > I found this commit upstream which touches the four failing tests, > though I don't really understand what it does: > > https://github.com/strace/strace/commit/4377e3a1535a0ec3a42da8a1366ad6943f4efa0e > > Mark: can you try the attached patch and see if it makes a difference? > Strace (still) builds for me with this patch, at least. I needed to add another phase to run 'tests/gen_tests.sh', and with that addition, strace-5.2 now successfully passes all tests on my system. I went ahead and pushed the resulting fix to the 'master' branch as commit 2426e2c94cdf9fcf28bba28b1e84b1aa5f652332. Thanks very much for your quick response to this issue. Best, Mark