From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Sample Subject: Re: 'core-updates' Q4 2019 Date: Wed, 23 Oct 2019 22:07:09 -0400 Message-ID: <875zkerj5e.fsf@ngyro.com> References: <87sgo252cq.fsf@devup.no> <878sprf1zk.fsf@posteo.net> <87ftjxd30v.fsf@gnu.org> <874l0ag5kv.fsf@posteo.net> <87tv8a0x8u.fsf@devup.no> <87v9snnlto.fsf@posteo.net> <87wod02714.fsf@ngyro.com> <87o8ycgkma.fsf@posteo.net> <20191021135850.qdplpdwap5nm6aoi@pelzflorian.localdomain> <87imoh7gz2.fsf@ngyro.com> <87a79sdusl.fsf@ngyro.com> <87lftbwdvg.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50271) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNSWu-0005ck-1e for guix-devel@gnu.org; Wed, 23 Oct 2019 22:07:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNSWs-0006Ix-OK for guix-devel@gnu.org; Wed, 23 Oct 2019 22:07:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40529) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iNSWs-0006Hl-Cw for guix-devel@gnu.org; Wed, 23 Oct 2019 22:07:10 -0400 In-Reply-To: <87lftbwdvg.fsf@devup.no> (Marius Bakke's message of "Wed, 23 Oct 2019 19:49:55 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Marius, Marius Bakke writes: > Timothy Sample writes: > >> [1] It=E2=80=99s not obvious, but if you edit the GDM configuration file >> generation code in =E2=80=9Cgnu/services/xorg.scm=E2=80=9D, you can enab= le debug output >> for GDM. The debug output is usually extremely helpful! > > Could that be exposed as a toggle in the service configuration? Indeed! It=E2=80=99s been on my list for ages. Thanks for the nudge. ;) How about the attached patch? I can confirm that it works, but would like a second opinion on the name, since it is annoying to change later. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-services-gdm-Add-debug-configuration-field.patch Content-Description: patch >From b3e577799c2dfabb2bed00b9f3715144155c2c43 Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Wed, 23 Oct 2019 21:57:52 -0400 Subject: [PATCH] services: gdm: Add 'debug?' configuration field. * gnu/services/xorg.scm ()[debug?]: New field. (gdm-configuration-file): Use it. --- gnu/services/xorg.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index 1d55e388a1..9c84f7413f 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -835,6 +835,7 @@ the GNOME desktop environment.") (allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t)) (auto-login? gdm-configuration-auto-login? (default #f)) (dbus-daemon gdm-configuration-dbus-daemon (default dbus-daemon-wrapper)) + (debug? gdm-configuration-debug? (default #f)) (default-user gdm-configuration-default-user (default #f)) (gnome-shell-assets gdm-configuration-gnome-shell-assets (default (list adwaita-icon-theme font-cantarell))) @@ -866,7 +867,9 @@ the GNOME desktop environment.") "WaylandEnable=false\n" "\n" "[debug]\n" - "#Enable=true\n" + "Enable=" (if (gdm-configuration-debug? config) + "true" + "false") "\n" "\n" "[security]\n" "#DisallowTCP=true\n" -- 2.23.0 --=-=-= Content-Type: text/plain Thanks! -- Tim --=-=-=--