From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Rosset <mike.rosset@gmail.com>
Subject: Re: [bug#39229] qt-build-system: Add QT_QPA_PLATFORM=offscreen?
Date: Wed, 22 Jan 2020 01:20:04 -0800
Message-ID: <875zh3luez.fsf@gmail.com>
References: <20200121212746.16054-1-h.goebel@crazy-compilers.com>
 <20200121212746.16054-7-h.goebel@crazy-compilers.com>
 <20200121234321.2e51854b@scratchpost.org>
 <d4dbba6d-c3ab-484b-a423-833aa36f606c@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:51355)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mike.rosset@gmail.com>) id 1iuCBM-0003Ty-3z
 for guix-devel@gnu.org; Wed, 22 Jan 2020 04:20:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mike.rosset@gmail.com>) id 1iuCBL-00042b-6D
 for guix-devel@gnu.org; Wed, 22 Jan 2020 04:20:16 -0500
In-reply-to: <d4dbba6d-c3ab-484b-a423-833aa36f606c@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: guix-patches@gnu.org
Cc: guix-devel <guix-devel@gnu.org>, 39229@debbugs.gnu.org


Hartmut Goebel writes:

> Hi Danny,
>
> (forwarding to guix-devel to eventually get more opinions on this)
>
> Am 21.01.20 um 23:43 schrieb Danny Milosavljevic:
>>> +         (add-before 'check 'check-setup
>>> +           (lambda _
>>> +             (setenv "QT_QPA_PLATFORM" "offscreen")
>>> +             #t)))))
>> Hmm, would it make sense to do that automatically in qt-build-system ?
>
> I would be fine with this, since I find myself adding this snippet quite
> often when building Qt/KDE applications. But there *might* be cases,
> where tests fail due to this setting. (While I'm not aware of one, I
> could imaging some test checks whether it is actually painting.)
>
> Thus I propose implementing this in some way to easily disable it if
> required: Either
>
> - by adding this a new phase (as in the snippet shown above), so it can
> easily be disabled
>
> - by adding another keyword-argument (proposal: `#:qpa-platform`,
> default: "offscreen", if +f, will not be set.
>
> WDYT?


I think adding this to qt-build-system with the keywords is a good
suggestion.

++

Mike